Skip to content

Commit a164407

Browse files
bmomjianbmomjian
committed
Add DROP COLUMN status from Hiroshi.
1 parent fa046b6 commit a164407

File tree

1 file changed

+96
-5
lines changed

1 file changed

+96
-5
lines changed

‎doc/TODO.detail/drop

Lines changed: 96 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ From pgsql-hackers-owner+M3040@hub.org Thu Jun 8 00:31:01 2000
22
Received: from renoir.op.net (root@renoir.op.net [207.29.195.4])
33
by candle.pha.pa.us (8.9.0/8.9.0) with ESMTP id AAA13157
44
for <pgman@candle.pha.pa.us>; Thu, 8 Jun 2000 00:31:00 -0400 (EDT)
5-
Received: from hub.org (root@hub.org [216.126.84.1]) by renoir.op.net (o1/$Revision: 1.3 $) with ESMTP id AAA01089 for <pgman@candle.pha.pa.us>; Thu, 8 Jun 2000 00:17:19 -0400 (EDT)
5+
Received: from hub.org (root@hub.org [216.126.84.1]) by renoir.op.net (o1/$Revision: 1.4 $) with ESMTP id AAA01089 for <pgman@candle.pha.pa.us>; Thu, 8 Jun 2000 00:17:19 -0400 (EDT)
66
Received: from hub.org (majordom@localhost [127.0.0.1])
77
by hub.org (8.10.1/8.10.1) with SMTP id e5846ib99782;
88
Thu, 8 Jun 2000 00:06:44 -0400 (EDT)
@@ -280,7 +280,7 @@ From Inoue@tpf.co.jp Sat Jun 10 01:01:01 2000
280280
Received: from renoir.op.net (root@renoir.op.net [207.29.195.4])
281281
by candle.pha.pa.us (8.9.0/8.9.0) with ESMTP id BAA10355
282282
for <pgman@candle.pha.pa.us>; Sat, 10 Jun 2000 01:01:00 -0400 (EDT)
283-
Received: from sd.tpf.co.jp (sd.tpf.co.jp [210.161.239.34]) by renoir.op.net (o1/$Revision: 1.3 $) with ESMTP id AAA25467 for <pgman@candle.pha.pa.us>; Sat, 10 Jun 2000 00:41:32 -0400 (EDT)
283+
Received: from sd.tpf.co.jp (sd.tpf.co.jp [210.161.239.34]) by renoir.op.net (o1/$Revision: 1.4 $) with ESMTP id AAA25467 for <pgman@candle.pha.pa.us>; Sat, 10 Jun 2000 00:41:32 -0400 (EDT)
284284
Received: from mcadnote1 (ppm110.noc.fukui.nsk.ne.jp [210.161.188.29] (may be forged))
285285
by sd.tpf.co.jp (2.5 Build 2640 (Berkeley 8.8.6)/8.8.4) with SMTP
286286
id NAA03125; Sat, 10 Jun 2000 13:40:40 +0900
@@ -411,7 +411,7 @@ From tgl@sss.pgh.pa.us Sat Jun 10 01:31:04 2000
411411
Received: from renoir.op.net (root@renoir.op.net [207.29.195.4])
412412
by candle.pha.pa.us (8.9.0/8.9.0) with ESMTP id BAA10922
413413
for <pgman@candle.pha.pa.us>; Sat, 10 Jun 2000 01:31:03 -0400 (EDT)
414-
Received: from sss2.sss.pgh.pa.us (sss.pgh.pa.us [209.114.166.2]) by renoir.op.net (o1/$Revision: 1.3 $) with ESMTP id BAA27265 for <pgman@candle.pha.pa.us>; Sat, 10 Jun 2000 01:16:07 -0400 (EDT)
414+
Received: from sss2.sss.pgh.pa.us (sss.pgh.pa.us [209.114.166.2]) by renoir.op.net (o1/$Revision: 1.4 $) with ESMTP id BAA27265 for <pgman@candle.pha.pa.us>; Sat, 10 Jun 2000 01:16:07 -0400 (EDT)
415415
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
416416
by sss2.sss.pgh.pa.us (8.9.3/8.9.3) with ESMTP id BAA06206;
417417
Sat, 10 Jun 2000 01:14:37 -0400 (EDT)
@@ -457,7 +457,7 @@ From dhogaza@pacifier.com Sat Jun 10 09:30:59 2000
457457
Received: from renoir.op.net (root@renoir.op.net [207.29.195.4])
458458
by candle.pha.pa.us (8.9.0/8.9.0) with ESMTP id JAA25987
459459
for <pgman@candle.pha.pa.us>; Sat, 10 Jun 2000 09:30:58 -0400 (EDT)
460-
Received: from smtp.pacifier.com (comet.pacifier.com [199.2.117.155]) by renoir.op.net (o1/$Revision: 1.3 $) with ESMTP id JAA18716 for <pgman@candle.pha.pa.us>; Sat, 10 Jun 2000 09:15:08 -0400 (EDT)
460+
Received: from smtp.pacifier.com (comet.pacifier.com [199.2.117.155]) by renoir.op.net (o1/$Revision: 1.4 $) with ESMTP id JAA18716 for <pgman@candle.pha.pa.us>; Sat, 10 Jun 2000 09:15:08 -0400 (EDT)
461461
Received: from desktop (dsl-dhogaza.pacifier.net [207.202.226.68])
462462
by smtp.pacifier.com (8.9.3/8.9.3pop) with SMTP id GAA15799;
463463
Sat, 10 Jun 2000 06:14:28 -0700 (PDT)
@@ -509,7 +509,7 @@ From tgl@sss.pgh.pa.us Sun Jun 11 12:31:03 2000
509509
Received: from renoir.op.net (root@renoir.op.net [207.29.195.4])
510510
by candle.pha.pa.us (8.9.0/8.9.0) with ESMTP id MAA05771
511511
for <pgman@candle.pha.pa.us>; Sun, 11 Jun 2000 12:31:01 -0400 (EDT)
512-
Received: from sss2.sss.pgh.pa.us (sss.pgh.pa.us [209.114.166.2]) by renoir.op.net (o1/$Revision: 1.3 $) with ESMTP id MAA19315 for <pgman@candle.pha.pa.us>; Sun, 11 Jun 2000 12:24:06 -0400 (EDT)
512+
Received: from sss2.sss.pgh.pa.us (sss.pgh.pa.us [209.114.166.2]) by renoir.op.net (o1/$Revision: 1.4 $) with ESMTP id MAA19315 for <pgman@candle.pha.pa.us>; Sun, 11 Jun 2000 12:24:06 -0400 (EDT)
513513
Received: from sss2.sss.pgh.pa.us (tgl@localhost [127.0.0.1])
514514
by sss2.sss.pgh.pa.us (8.9.3/8.9.3) with ESMTP id MAA09503;
515515
Sun, 11 Jun 2000 12:22:42 -0400 (EDT)
@@ -839,3 +839,94 @@ a column. Consider needing to drop several columns...
839839

840840
************
841841

842+
From pgsql-hackers-owner+M18768=candle.pha.pa.us=pgman@postgresql.org Wed Feb 13 03:52:00 2002
843+
Return-path: <pgsql-hackers-owner+M18768=candle.pha.pa.us=pgman@postgresql.org>
844+
Received: from server1.pgsql.org (www.postgresql.org [64.49.215.9])
845+
by candle.pha.pa.us (8.11.6/8.10.1) with SMTP id g1D8pxP21056
846+
for <pgman@candle.pha.pa.us>; Wed, 13 Feb 2002 03:52:00 -0500 (EST)
847+
Received: (qmail 97959 invoked by alias); 13 Feb 2002 08:51:46 -0000
848+
Received: from unknown (HELO postgresql.org) (64.49.215.8)
849+
by www.postgresql.org with SMTP; 13 Feb 2002 08:51:46 -0000
850+
Received: from sd.tpf.co.jp (sd.tpf.co.jp [210.161.239.34])
851+
by postgresql.org (8.11.3/8.11.4) with SMTP id g1D8mRE97432
852+
for <pgsql-hackers@postgresql.org>; Wed, 13 Feb 2002 03:48:28 -0500 (EST)
853+
(envelope-from Inoue@tpf.co.jp)
854+
Received: (qmail 26891 invoked from network); 13 Feb 2002 08:48:27 -0000
855+
Received: from unknown (HELO viscomail.tpf.co.jp) (100.0.0.108)
856+
by sd2.tpf-fw-c.co.jp with SMTP; 13 Feb 2002 08:48:27 -0000
857+
Received: from tpf.co.jp (3dgateway1 [126.0.1.60])
858+
by viscomail.tpf.co.jp (8.8.8+Sun/8.8.8) with ESMTP id RAA01019;
859+
Wed, 13 Feb 2002 17:48:20 +0900 (JST)
860+
Message-ID: <3C6A2861.6E71A124@tpf.co.jp>
861+
Date: Wed, 13 Feb 2002 17:48:33 +0900
862+
From: Hiroshi Inoue <Inoue@tpf.co.jp>
863+
X-Mailer: Mozilla 4.73 [ja] (Windows NT 5.0; U)
864+
X-Accept-Language: ja
865+
MIME-Version: 1.0
866+
To: Christopher Kings-Lynne <chriskl@familyhealth.com.au>
867+
cc: Tom Lane <tgl@sss.pgh.pa.us>,
868+
Kovacs Zoltan <kovacsz@pc10.radnoti-szeged.sulinet.hu>,
869+
pgsql-hackers@postgresql.org
870+
Subject: Re: [HACKERS] alter table drop column status
871+
References: <GNELIHDDFBOCMGBFGEFOMEFPCBAA.chriskl@familyhealth.com.au>
872+
Content-Type: text/plain; charset=iso-2022-jp
873+
Content-Transfer-Encoding: 7bit
874+
Precedence: bulk
875+
Sender: pgsql-hackers-owner@postgresql.org
876+
Status: OR
877+
878+
Christopher Kings-Lynne wrote:
879+
>
880+
> > No there was an unapplied hack which uses logical/physical
881+
> > attribute numbers. I have synchronized it with cvs for a
882+
> > year or so but stop it now. Though it had some flaws It
883+
> > solved the following TODOs.
884+
> >
885+
> > * Add ALTER TABLE DROP COLUMN feature
886+
> > * ALTER TABLE ADD COLUMN to inherited table put column in wrong place
887+
> > * Prevent column dropping if column is used by foreign key
888+
>
889+
> This seems fantastic - why can't this be committed? Surely if it's
890+
> committed then the flaws will fairly quickly be ironed out? Even if it has
891+
> flaws, then if we say 'this function is not yet stable' at least people can
892+
> start testing it and reporting the problems?
893+
>
894+
> > I gave up to apply the hack mainly because it may introduce
895+
> > the maintenance headache.
896+
>
897+
> Is it a maintenance headache just for you to keep it up to date, or how
898+
> would it be a maintenance headache if it were committed?
899+
900+
Probably(oops I don't remember well now sorry) the main
901+
reason why I didn't insist to apply the patch was that
902+
it wasn't so clean as I had expected.
903+
My trial implementation uses logical(for clients) and
904+
physical (for backend internal) attribute numbers but
905+
there were many places where I wasn't able to judge which
906+
to use immediately. I'm pretty suspicious if a developer
907+
could be careful about the choise when he is implementing
908+
an irrevant feature. (Un)fortunately the numbers have
909+
the same values mostly and he could hardly notice the
910+
mistake even if he chose the wrong attribute numbers.
911+
I'm not sure if I myself chose the right attribute numbers
912+
everywhere in my implementation.
913+
In addtion (probably) there were some pretty essential
914+
flaws. I intended to manage the backend internal
915+
object references without the logical attribute
916+
numbers but I found it difficult in some cases
917+
(probably the handling of virtual(not existent
918+
in any real table) tuples).
919+
920+
Sorry it was more than 1 year ago when I implemented
921+
it and I can't remember well what I'd thougth then.
922+
Though I'd kept my local branch up to date for
923+
about a year, it's about half a year since I touched
924+
the stuff last.
925+
926+
regards,
927+
Hiroshi Inoue
928+
929+
---------------------------(end of broadcast)---------------------------
930+
TIP 2: you can get off all lists at once with the unregister command
931+
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
932+

0 commit comments

Comments
 (0)