pg_basebackup: Add missing PQclear in error path

danielgustafsson · danielgustafsson · commit a19db0827496 · 2025-03-25T17:24:23.000+01:00
This adds a missing PQclear in the error path of StreamLogicalLog, a fix in the same vein as e889422 with an equivalent low impact. Author: Steven Niu <niushiji@gmail.com> Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Discussion: https://postgr.es/m/c4b1c627-a3e4-4347-a670-1e28a43ce0eb@gmail.com
diff --git a/src/bin/pg_basebackup/pg_recvlogical.c b/src/bin/pg_basebackup/pg_recvlogical.c
@@ -633,6 +633,7 @@ StreamLogicalLog(void)
 	{
 		pg_log_error("unexpected termination of replication stream: %s",
 					 PQresultErrorMessage(res));
+		PQclear(res);
 		goto error;
 	}
 	PQclear(res);

Original file line number	Diff line number	Diff line change
`@@ -633,6 +633,7 @@ StreamLogicalLog(void)`
`633`	`633`	`{`
`634`	`634`	`pg_log_error("unexpected termination of replication stream: %s",`
`635`	`635`	`PQresultErrorMessage(res));`
	`636`	`+ PQclear(res);`
`636`	`637`	`goto error;`
`637`	`638`	`}`
`638`	`639`	`PQclear(res);`