Clean up float4byval and float8byval handling by dealing with them completely

mhagander · mhagander · commit a31b03ba2710 · 2008-04-21T18:37:28.000Z
from inside the build script.
diff --git a/src/include/pg_config.h.win32 b/src/include/pg_config.h.win32
@@ -53,13 +53,6 @@
    (--enable-thread-safety) */
 #define ENABLE_THREAD_SAFETY 1
 
-/* float4 values are passed by value if 'true', by reference if 'false' */
-#define FLOAT4PASSBYVAL true
-
-/* float8, int8, and related values are passed by value if 'true', by
-   reference if 'false' */
-#define FLOAT8PASSBYVAL false
-
 /* Define to 1 if getpwuid_r() takes a 5th argument. */
 /* #undef GETPWUID_R_5ARG */
 
@@ -623,14 +616,6 @@
 /* Define to 1 to build with Bonjour support. (--with-bonjour) */
 /* #undef USE_BONJOUR */
 
-/* Define to 1 if you want float4 values to be passed by value.
-   (--enable-float4-byval) */
-#define USE_FLOAT4_BYVAL 1
-
-/* Define to 1 if you want float8, int8, etc values to be passed by value.
-   (--enable-float8-byval) */
-/* #undef USE_FLOAT8_BYVAL */
-
 /* Define to 1 if you want 64-bit integer timestamp and interval support.
    (--enable-integer-datetimes) */
 /* #undef USE_INTEGER_DATETIMES */
diff --git a/src/tools/msvc/Solution.pm b/src/tools/msvc/Solution.pm
@@ -3,7 +3,7 @@ package Solution;
 #
 # Package that encapsulates a Visual C++ solution file generation
 #
-# $PostgreSQL: pgsql/src/tools/msvc/Solution.pm,v 1.39 2008/04/21 10:01:32 mha Exp $
+# $PostgreSQL: pgsql/src/tools/msvc/Solution.pm,v 1.40 2008/04/21 18:37:28 mha Exp $
 #
 use Carp;
 use strict;
@@ -118,19 +118,24 @@ s{PG_VERSION_STR "[^"]+"}{__STRINGIFY(x) #x\n#define __STRINGIFY2(z) __STRINGIFY
         print O "#define USE_SSL 1\n" if ($self->{options}->{openssl});
         print O "#define ENABLE_NLS 1\n" if ($self->{options}->{nls});
         
-        unless ($self->{options}->{float4byval}) 
+        if ($self->{options}->{float4byval}) 
+        {
+            print O "#define USE_FLOAT4_BYVAL 1\n";
+            print O "#define FLOAT4PASSBYVAL true\n";
+        }
+        else
         {
-            # float4byval is the default, so undefine
-            print O "#undef USE_FLOAT4_BYVAL\n";
-            print O "#undef FLOAT4PASSBYVAL\n";
             print O "#define FLOAT4PASSBYVAL false\n";
         }
         if ($self->{options}->{float8byval})
         {
-            print O "#define USE_FLOAT8_BYVAL\n";
-            print O "#undef FLOAT8PASSBYVAL\n";
+            print O "#define USE_FLOAT8_BYVAL 1\n";
             print O "#define FLOAT8PASSBYVAL true\n";
         }
+        else
+        {
+            print O "#define FLOAT8PASSBYVAL false\n";
+        }
 
         if ($self->{options}->{uuid})
         {

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ package Solution;`
`3`	`3`	`#`
`4`	`4`	`# Package that encapsulates a Visual C++ solution file generation`
`5`	`5`	`#`
`6`		`-# $PostgreSQL: pgsql/src/tools/msvc/Solution.pm,v 1.39 2008/04/21 10:01:32 mha Exp $`
	`6`	`+# $PostgreSQL: pgsql/src/tools/msvc/Solution.pm,v 1.40 2008/04/21 18:37:28 mha Exp $`
`7`	`7`	`#`
`8`	`8`	`use Carp;`
`9`	`9`	`use strict;`
`@@ -118,19 +118,24 @@ s{PG_VERSION_STR "[^"]+"}{__STRINGIFY(x) #x\n#define __STRINGIFY2(z) __STRINGIFY`
`118`	`118`	`print O "#define USE_SSL 1\n" if ($self->{options}->{openssl});`
`119`	`119`	`print O "#define ENABLE_NLS 1\n" if ($self->{options}->{nls});`
`120`	`120`
`121`		`- unless ($self->{options}->{float4byval})`
	`121`	`+ if ($self->{options}->{float4byval})`
	`122`	`+ {`
	`123`	`+ print O "#define USE_FLOAT4_BYVAL 1\n";`
	`124`	`+ print O "#define FLOAT4PASSBYVAL true\n";`
	`125`	`+ }`
	`126`	`+ else`
`122`	`127`	`{`
`123`		`- # float4byval is the default, so undefine`
`124`		`- print O "#undef USE_FLOAT4_BYVAL\n";`
`125`		`- print O "#undef FLOAT4PASSBYVAL\n";`
`126`	`128`	`print O "#define FLOAT4PASSBYVAL false\n";`
`127`	`129`	`}`
`128`	`130`	`if ($self->{options}->{float8byval})`
`129`	`131`	`{`
`130`		`- print O "#define USE_FLOAT8_BYVAL\n";`
`131`		`- print O "#undef FLOAT8PASSBYVAL\n";`
	`132`	`+ print O "#define USE_FLOAT8_BYVAL 1\n";`
`132`	`133`	`print O "#define FLOAT8PASSBYVAL true\n";`
`133`	`134`	`}`
	`135`	`+ else`
	`136`	`+ {`
	`137`	`+ print O "#define FLOAT8PASSBYVAL false\n";`
	`138`	`+ }`
`134`	`139`
`135`	`140`	`if ($self->{options}->{uuid})`
`136`	`141`	`{`