Consistently set all fields in pg_stat_replication to null instead of 0

mhagander · mhagander · commit a91bdf67c49a · 2015-12-13T16:53:38.000+01:00
Previously the "sent" field would be set to 0 and all other xlog
pointers be set to NULL if there were no valid values (such as when
in a backup sending walsender).
diff --git a/src/backend/replication/walsender.c b/src/backend/replication/walsender.c
@@ -2822,6 +2822,9 @@ pg_stat_get_wal_senders(PG_FUNCTION_ARGS)
 		else
 		{
 			values[1] = CStringGetTextDatum(WalSndGetStateString(state));
+
+			if (XLogRecPtrIsInvalid(sentPtr))
+				nulls[2] = true;
 			values[2] = LSNGetDatum(sentPtr);
 
 			if (XLogRecPtrIsInvalid(write))

Original file line number	Diff line number	Diff line change
`@@ -2822,6 +2822,9 @@ pg_stat_get_wal_senders(PG_FUNCTION_ARGS)`
`2822`	`2822`	`else`
`2823`	`2823`	`{`
`2824`	`2824`	`values[1] = CStringGetTextDatum(WalSndGetStateString(state));`
	`2825`	`+`
	`2826`	`+ if (XLogRecPtrIsInvalid(sentPtr))`
	`2827`	`+ nulls[2] = true;`
`2825`	`2828`	`values[2] = LSNGetDatum(sentPtr);`
`2826`	`2829`
`2827`	`2830`	`if (XLogRecPtrIsInvalid(write))`