Skip to content

Commit a9659fb

Browse files
committed
Use a slightly more liberal regex to detect Visual Studio version
Apparently in some language versions of Visual Studio nmake outputs some material after the version number and before the end of the line. This has been seen in Chinese versions. Therefore, we no longer demand that the version string comes at the end of a line. Per complaint from Cuiping Lin. Backpatch to all live branches.
1 parent 9e24109 commit a9659fb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/tools/msvc/VSObjectFactory.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ sub DetermineVisualStudioVersion
120120
$? >> 8 == 0
121121
or croak
122122
"Unable to determine Visual Studio version: The nmake command wasn't found.";
123-
if ($output =~ /(\d+)\.(\d+)\.\d+(\.\d+)?$/m)
123+
if ($output =~ /(\d+)\.(\d+)\.\d+(\.\d+)?/)
124124
{
125125
return _GetVisualStudioVersion($1, $2);
126126
}

0 commit comments

Comments
 (0)