Correct a thinko in pgbench that might result in incorrectly ignoring an

Neil Conway · Neil Conway · commit a99b2852ca79 · 2005-05-24T00:26:40.000Z
error condition when executing some DDL. Per report from ITAGAKI Takahiro.
diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
@@ -1,5 +1,5 @@
 /*
- * $PostgreSQL: pgsql/contrib/pgbench/pgbench.c,v 1.35 2004/11/09 06:09:31 neilc Exp $
+ * $PostgreSQL: pgsql/contrib/pgbench/pgbench.c,v 1.36 2005/05/24 00:26:40 neilc Exp $
  *
  * pgbench: a simple TPC-B like benchmark program for PostgreSQL
  * written by Tatsuo Ishii
@@ -622,7 +622,7 @@ init(void)
 	for (i = 0; i < (sizeof(DDLAFTERs) / sizeof(char *)); i++)
 	{
 		res = PQexec(con, DDLAFTERs[i]);
-		if (strncmp(DDLs[i], "drop", 4) && PQresultStatus(res) != PGRES_COMMAND_OK)
+		if (PQresultStatus(res) != PGRES_COMMAND_OK)
 		{
 			fprintf(stderr, "%s", PQerrorMessage(con));
 			exit(1);

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/*`
`2`		`- * $PostgreSQL: pgsql/contrib/pgbench/pgbench.c,v 1.35 2004/11/09 06:09:31 neilc Exp $`
	`2`	`+ * $PostgreSQL: pgsql/contrib/pgbench/pgbench.c,v 1.36 2005/05/24 00:26:40 neilc Exp $`
`3`	`3`	`*`
`4`	`4`	`* pgbench: a simple TPC-B like benchmark program for PostgreSQL`
`5`	`5`	`* written by Tatsuo Ishii`
`@@ -622,7 +622,7 @@ init(void)`
`622`	`622`	`for (i = 0; i < (sizeof(DDLAFTERs) / sizeof(char *)); i++)`
`623`	`623`	`{`
`624`	`624`	`res = PQexec(con, DDLAFTERs[i]);`
`625`		`- if (strncmp(DDLs[i], "drop", 4) && PQresultStatus(res) != PGRES_COMMAND_OK)`
	`625`	`+ if (PQresultStatus(res) != PGRES_COMMAND_OK)`
`626`	`626`	`{`
`627`	`627`	`fprintf(stderr, "%s", PQerrorMessage(con));`
`628`	`628`	`exit(1);`