Back-patch fix for erroneous use of strcmp().

tglsfdc · tglsfdc · commit aa09aaabff78 · 2000-09-23T21:32:55.000Z
diff --git a/src/backend/utils/adt/ruleutils.c b/src/backend/utils/adt/ruleutils.c
@@ -3,7 +3,7 @@
  *			  out of its tuple
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.48 2000/04/12 17:15:51 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.48.2.1 2000/09/23 21:32:55 tgl Exp $
  *
  *	  This software is copyrighted by Jan Wieck - Hamburg.
  *
@@ -956,7 +956,7 @@ get_select_query_def(Query *query, deparse_context *context)
 
 		/* Check if we must say AS ... */
 		if (!IsA(tle->expr, Var))
-			tell_as = strcmp(tle->resdom->resname, "?column?");
+			tell_as = (strcmp(tle->resdom->resname, "?column?") != 0);
 		else
 		{
 			Var		   *var = (Var *) (tle->expr);

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`* out of its tuple`
`4`	`4`	`*`
`5`	`5`	`* IDENTIFICATION`
`6`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.48 2000/04/12 17:15:51 momjian Exp $`
	`6`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/ruleutils.c,v 1.48.2.1 2000/09/23 21:32:55 tgl Exp $`
`7`	`7`	`*`
`8`	`8`	`* This software is copyrighted by Jan Wieck - Hamburg.`
`9`	`9`	`*`
`@@ -956,7 +956,7 @@ get_select_query_def(Query query, deparse_context context)`
`956`	`956`
`957`	`957`	`/* Check if we must say AS ... */`
`958`	`958`	`if (!IsA(tle->expr, Var))`
`959`		`- tell_as = strcmp(tle->resdom->resname, "?column?");`
	`959`	`+ tell_as = (strcmp(tle->resdom->resname, "?column?") != 0);`
`960`	`960`	`else`
`961`	`961`	`{`
`962`	`962`	`Var var = (Var ) (tle->expr);`