issue_warnings() has no business freeing its parameter, especially not when

tglsfdc · tglsfdc · commit add8044778a9 · 2010-05-23T16:54:13.000Z
its sole caller does that too.  Jan Matousek, via Pavel Stehule
diff --git a/contrib/pg_upgrade/check.c b/contrib/pg_upgrade/check.c
@@ -154,7 +154,6 @@ issue_warnings(migratorContext *ctx, char *sequence_script_file_name)
 					  ctx->new.bindir, ctx->new.port, sequence_script_file_name,
 					  ctx->logfile);
 			unlink(sequence_script_file_name);
-			pg_free(sequence_script_file_name);
 			check_ok(ctx);
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -154,7 +154,6 @@ issue_warnings(migratorContext ctx, char sequence_script_file_name)`
`154`	`154`	`ctx->new.bindir, ctx->new.port, sequence_script_file_name,`
`155`	`155`	`ctx->logfile);`
`156`	`156`	`unlink(sequence_script_file_name);`
`157`		`- pg_free(sequence_script_file_name);`
`158`	`157`	`check_ok(ctx);`
`159`	`158`	`}`
`160`	`159`