Prevent 006_transfer_modes.pl from leaving files behind.

nathan-bossart · nathan-bossart · commit b0a4c3e88b8b · 2025-04-08T10:57:31.000-05:00
This test was leaving files like delete_old_cluster.{sh,bat} in the source directory for VPATH and meson builds. To fix, change the directory to tmp_check before running the test, as was done in commits 15b6d21, 8af917b, and c462b05. Oversight in commit af0d490. Reported-by: Andrew Dunstan <andrew@dunslane.net> (on Discord) Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Andrew Dunstan <andrew@dunslane.net> Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/Z_RHkG770w3SE0yU%40nathan
diff --git a/src/bin/pg_upgrade/t/006_transfer_modes.pl b/src/bin/pg_upgrade/t/006_transfer_modes.pl
@@ -102,6 +102,11 @@ sub test_mode
 	$new->clean_node();
 }
 
+# Run pg_upgrade in tmp_check to avoid leaving files like
+# delete_old_cluster.{sh,bat} in the source directory for VPATH and meson
+# builds.
+chdir ${PostgreSQL::Test::Utils::tmp_check};
+
 test_mode('--clone');
 test_mode('--copy');
 test_mode('--copy-file-range');
