Skip to content

Commit b1d7912

Browse files
Correct obsolete UNION hash aggs comment.
Oversight in commit 1f39bce, which added disk-based hash aggregation. Backpatch: 13-, where disk-based hash aggregation was introduced.
1 parent f36e820 commit b1d7912

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

src/backend/optimizer/prep/prepunion.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -944,11 +944,10 @@ make_union_unique(SetOperationStmt *op, Path *path, List *tlist,
944944

945945
/*
946946
* XXX for the moment, take the number of distinct groups as equal to the
947-
* total input size, ie, the worst case. This is too conservative, but we
948-
* don't want to risk having the hashtable overrun memory; also, it's not
949-
* clear how to get a decent estimate of the true size. One should note
950-
* as well the propensity of novices to write UNION rather than UNION ALL
951-
* even when they don't expect any duplicates...
947+
* total input size, ie, the worst case. This is too conservative, but
948+
* it's not clear how to get a decent estimate of the true size. One
949+
* should note as well the propensity of novices to write UNION rather
950+
* than UNION ALL even when they don't expect any duplicates...
952951
*/
953952
dNumGroups = path->rows;
954953

0 commit comments

Comments
 (0)