Add table relcache invalidation to index builds.

petergeoghegan · petergeoghegan · commit b3f919da0754 · 2018-08-03T15:11:31.000-07:00
It's necessary to make sure that owning tables have a relcache invalidation prior to advancing the command counter to make newly-entered catalog tuples for the index visible. inval.c must be able to maintain the consistency of the local caches in the event of transaction abort. There is usually only a problem when CREATE INDEX transactions abort, since there is a generic invalidation once we reach index_update_stats(). This bug is of long standing. Problems were made much more likely by the addition of parallel CREATE INDEX (commit 9da0cc3), but it is strongly suspected that similar problems can be triggered without involving plan_create_index_workers(). (plan_create_index_workers() triggers a relcache build or rebuild, which previously only happened in rare edge cases.) Author: Peter Geoghegan Reported-By: Luca Ferrari Diagnosed-By: Andres Freund Reviewed-By: Andres Freund Discussion: https://postgr.es/m/CAKoxK+5fVodiCtMsXKV_1YAKXbzwSfp7DgDqUmcUAzeAhf=HEQ@mail.gmail.com Backpatch: 9.3-
diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
@@ -978,6 +978,12 @@ index_create(Relation heapRelation,
 						!concurrent && !invalid,
 						!concurrent);
 
+	/*
+	 * Register relcache invalidation on the indexes' heap relation, to
+	 * maintain consistency of its index list
+	 */
+	CacheInvalidateRelcache(heapRelation);
+
 	/* update pg_inherits, if needed */
 	if (OidIsValid(parentIndexRelid))
 		StoreSingleInheritance(indexRelationId, parentIndexRelid, 1);
