Mark PlanState as an abstract node type.

tglsfdc · tglsfdc · commit b4f79d278f2a · 2022-07-09T13:35:37.000-04:00
In the same vein as commit 251154b, make it clear that we never instantiate PlanState. Also mark MemoryContextData as abstract. This has no effect right now, since memnodes.h isn't one of the files fed to gen_node_support.pl. But it seems like good documentation and future-proofing.
diff --git a/src/include/nodes/execnodes.h b/src/include/nodes/execnodes.h
@@ -999,6 +999,8 @@ typedef TupleTableSlot *(*ExecProcNodeMtd) (struct PlanState *pstate);
  */
 typedef struct PlanState
 {
+	pg_node_attr(abstract)
+
 	NodeTag		type;
 
 	Plan	   *plan;			/* associated Plan node */
diff --git a/src/include/nodes/memnodes.h b/src/include/nodes/memnodes.h
@@ -77,6 +77,8 @@ typedef struct MemoryContextMethods
 
 typedef struct MemoryContextData
 {
+	pg_node_attr(abstract)		/* there are no nodes of this type */
+
 	NodeTag		type;			/* identifies exact kind of context */
 	/* these two fields are placed here to minimize alignment wastage: */
 	bool		isReset;		/* T = no space alloced since last reset */
diff --git a/src/test/modules/test_oat_hooks/test_oat_hooks.c b/src/test/modules/test_oat_hooks/test_oat_hooks.c
@@ -618,9 +618,6 @@ nodetag_to_string(NodeTag tag)
 		case T_PlanInvalItem:
 			return "PlanInvalItem";
 			break;
-		case T_PlanState:
-			return "PlanState";
-			break;
 		case T_ResultState:
 			return "ResultState";
 			break;

Original file line number	Diff line number	Diff line change
`@@ -999,6 +999,8 @@ typedef TupleTableSlot (ExecProcNodeMtd) (struct PlanState *pstate);`
`999`	`999`	`*/`
`1000`	`1000`	`typedef struct PlanState`
`1001`	`1001`	`{`
	`1002`	`+ pg_node_attr(abstract)`
	`1003`	`+`
`1002`	`1004`	`NodeTag type;`
`1003`	`1005`
`1004`	`1006`	`Plan plan; / associated Plan node */`
Original file line number	Diff line number	Diff line change
`@@ -77,6 +77,8 @@ typedef struct MemoryContextMethods`
`77`	`77`
`78`	`78`	`typedef struct MemoryContextData`
`79`	`79`	`{`
	`80`	`+ pg_node_attr(abstract) /* there are no nodes of this type */`
	`81`	`+`
`80`	`82`	`NodeTag type; /* identifies exact kind of context */`
`81`	`83`	`/* these two fields are placed here to minimize alignment wastage: */`
`82`	`84`	`bool isReset; /* T = no space alloced since last reset */`