ecpg: Restore detection of unsupported COPY FROM STDIN.

MasaoFujii · MasaoFujii · commit ba2dbedd5396 · 2025-01-15T01:24:24.000+09:00
The ecpg command includes code to warn about unsupported COPY FROM STDIN statements in input files. However, since commit 3d009e4, this functionality has been broken due to a bug introduced in that commit, causing ecpg to fail to detect the statement. This commit resolves the issue, restoring ecpg's ability to detect COPY FROM STDIN and issue a warning as intended. Back-patch to all supported versions. Author: Ryo Kanbayashi Reviewed-by: Hayato Kuroda, Tom Lane Discussion: https://postgr.es/m/CANOn0Ez_t5uDCUEV8c1YORMisJiU5wu681eEVZzgKwOeiKhkqQ@mail.gmail.com
diff --git a/src/interfaces/ecpg/preproc/ecpg.addons b/src/interfaces/ecpg/preproc/ecpg.addons
@@ -248,7 +248,7 @@ ECPG: where_or_current_clauseWHERECURRENT_POFcursor_name block
 		$$ = cat_str(2,mm_strdup("where current of"), cursor_marker);
 	}
 ECPG: CopyStmtCOPYopt_binaryqualified_nameopt_column_listcopy_fromopt_programcopy_file_namecopy_delimiteropt_withcopy_optionswhere_clause addon
-			if (strcmp($6, "from") == 0 &&
+			if (strcmp($5, "from") == 0 &&
 			   (strcmp($7, "stdin") == 0 || strcmp($7, "stdout") == 0))
 				mmerror(PARSE_ERROR, ET_WARNING, "COPY FROM STDIN is not implemented");
 ECPG: var_valueNumericOnly addon

Original file line number	Diff line number	Diff line change
`@@ -248,7 +248,7 @@ ECPG: where_or_current_clauseWHERECURRENT_POFcursor_name block`
`248`	`248`	`$$ = cat_str(2,mm_strdup("where current of"), cursor_marker);`
`249`	`249`	`}`
`250`	`250`	`ECPG: CopyStmtCOPYopt_binaryqualified_nameopt_column_listcopy_fromopt_programcopy_file_namecopy_delimiteropt_withcopy_optionswhere_clause addon`
`251`		`- if (strcmp($6, "from") == 0 &&`
	`251`	`+ if (strcmp($5, "from") == 0 &&`
`252`	`252`	`(strcmp($7, "stdin") == 0 \|\| strcmp($7, "stdout") == 0))`
`253`	`253`	`mmerror(PARSE_ERROR, ET_WARNING, "COPY FROM STDIN is not implemented");`
`254`	`254`	`ECPG: var_valueNumericOnly addon`