Don't use 'return' where you should use 'PG_RETURN_xxx'.

tglsfdc · tglsfdc · commit ba3fb57d8171 · 2009-07-07T19:28:56.000Z
diff --git a/src/backend/utils/mb/mbutils.c b/src/backend/utils/mb/mbutils.c
@@ -4,7 +4,7 @@
  *
  * Tatsuo Ishii
  *
- * $PostgreSQL: pgsql/src/backend/utils/mb/mbutils.c,v 1.88 2009/07/07 18:23:14 petere Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/mb/mbutils.c,v 1.89 2009/07/07 19:28:56 tgl Exp $
  */
 #include "postgres.h"
 
@@ -488,7 +488,7 @@ pg_encoding_max_length_sql(PG_FUNCTION_ARGS)
 	int encoding = PG_GETARG_INT32(0);
 
 	if (PG_VALID_ENCODING(encoding))
-		return pg_wchar_table[encoding].maxmblen;
+		PG_RETURN_INT32(pg_wchar_table[encoding].maxmblen);
 	else
 		PG_RETURN_NULL();
 }

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@`
`4`	`4`	`*`
`5`	`5`	`* Tatsuo Ishii`
`6`	`6`	`*`
`7`		`- * $PostgreSQL: pgsql/src/backend/utils/mb/mbutils.c,v 1.88 2009/07/07 18:23:14 petere Exp $`
	`7`	`+ * $PostgreSQL: pgsql/src/backend/utils/mb/mbutils.c,v 1.89 2009/07/07 19:28:56 tgl Exp $`
`8`	`8`	`*/`
`9`	`9`	`#include "postgres.h"`
`10`	`10`
`@@ -488,7 +488,7 @@ pg_encoding_max_length_sql(PG_FUNCTION_ARGS)`
`488`	`488`	`int encoding = PG_GETARG_INT32(0);`
`489`	`489`
`490`	`490`	`if (PG_VALID_ENCODING(encoding))`
`491`		`- return pg_wchar_table[encoding].maxmblen;`
	`491`	`+ PG_RETURN_INT32(pg_wchar_table[encoding].maxmblen);`
`492`	`492`	`else`
`493`	`493`	`PG_RETURN_NULL();`
`494`	`494`	`}`