Keep heap open until new heap generated in RMV.

kgrittn · kgrittn · commit bc06faeb78c0 · 2013-11-06T12:26:36.000-06:00
Early close became apparent when invalidation messages were
processed in a new location under CLOBBER_CACHE_ALWAYS builds, due
to additional locking.

Back-patch to 9.3
diff --git a/src/backend/commands/matview.c b/src/backend/commands/matview.c
@@ -208,8 +208,6 @@ ExecRefreshMatView(RefreshMatViewStmt *stmt, const char *queryString,
 
 	tableSpace = matviewRel->rd_rel->reltablespace;
 
-	heap_close(matviewRel, NoLock);
-
 	/* Create the transient table that will receive the regenerated data. */
 	OIDNewHeap = make_new_heap(matviewOid, tableSpace);
 	dest = CreateTransientRelDestReceiver(OIDNewHeap);
@@ -218,6 +216,8 @@ ExecRefreshMatView(RefreshMatViewStmt *stmt, const char *queryString,
 	if (!stmt->skipData)
 		refresh_matview_datafill(dest, dataQuery, queryString);
 
+	heap_close(matviewRel, NoLock);
+
 	/*
 	 * Swap the physical files of the target and transient tables, then
 	 * rebuild the target's indexes and throw away the transient table.
