Skip to content

Commit bc49ab3

Browse files
Improve pgindent release workflow.
Update RELEASE_CHANGES to direct the reader towards completing the steps outlined in the pgindent README, both as a pre-beta task and as a task to be performed when starting a new development cycle. This makes it less likely that somebody will miss updating the .git-blame-ignore-revs file when running pgindent against the tree as a routine release change task. Author: Peter Geoghegan <pg@bowt.ie> Reviewed-By: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CAH2-Wz=2PjF4As8dWECArsXxLKganYmQ-s0UeGqHHbHhqDKqeA@mail.gmail.com
1 parent 6f5d9bc commit bc49ab3

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

src/tools/RELEASE_CHANGES

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,7 @@ but there may be reasons to do them at other times as well.
7070

7171
* Run mechanical code beautification tools:
7272
pgindent, pgperltidy, and "make reformat-dat-files"
73-
(see src/tools/pgindent/README)
74-
75-
* Update .git-blame-ignore-revs. It should contain all of the newly
76-
created code beautification commits. Make sure that you use
77-
full-length commit hashes for this.
73+
(complete steps from src/tools/pgindent/README)
7874

7975
* Renumber any manually-assigned OIDs between 8000 and 9999
8076
to lower numbers, using renumber_oids.pl (see notes in bki.sgml)
@@ -90,7 +86,7 @@ Starting a New Development Cycle
9086
================================
9187

9288
* Typically, we do pgindent and perltidy runs just before branching,
93-
as well as before beta
89+
as well as before beta (complete steps from src/tools/pgindent/README)
9490

9591
* Create a branch in git for maintenance of the previous release
9692
o on master branch, do:

src/tools/pgindent/README

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,8 @@ you used.
8282

8383
4) Add the newly created commits to the .git-blame-ignore-revs file so
8484
that "git blame" ignores the commits (for anybody that has opted-in
85-
to using the ignore file).
85+
to using the ignore file). Follow the instructions that appear at
86+
the top of the .git-blame-ignore-revs file.
8687

8788
Another "git commit" will be required for your ignore file changes.
8889

0 commit comments

Comments
 (0)