Skip to content

Commit bcd7e88

Browse files
committed
Remove superfluous -DFRONTEND.
The majority practice is to add -DFRONTEND in directories building files that are, at other times, built for the backend. Some directories lacking that property added a noise -DFRONTEND in one build system. Remove the excess flags, for consistency.
1 parent 151e747 commit bcd7e88

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

src/bin/pg_upgrade/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ OBJS = check.o controldata.o dump.o exec.o file.o function.o info.o \
1111
option.o page.o parallel.o pg_upgrade.o relfilenode.o server.o \
1212
tablespace.o util.o version.o $(WIN32RES)
1313

14-
override CPPFLAGS := -DFRONTEND -DDLSUFFIX=\"$(DLSUFFIX)\" -I$(srcdir) -I$(libpq_srcdir) $(CPPFLAGS)
14+
override CPPFLAGS := -DDLSUFFIX=\"$(DLSUFFIX)\" -I$(srcdir) -I$(libpq_srcdir) $(CPPFLAGS)
1515

1616

1717
all: pg_upgrade

src/tools/msvc/Mkvcbuild.pm

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,6 @@ sub mkvcbuild
379379
$pgregress_ecpg->AddIncludeDir('src\port');
380380
$pgregress_ecpg->AddIncludeDir('src\test\regress');
381381
$pgregress_ecpg->AddDefine('HOST_TUPLE="i686-pc-win32vc"');
382-
$pgregress_ecpg->AddDefine('FRONTEND');
383382
$pgregress_ecpg->AddLibrary('ws2_32.lib');
384383
$pgregress_ecpg->AddDirResourceFile('src\interfaces\ecpg\test');
385384
$pgregress_ecpg->AddReference($libpgcommon, $libpgport);
@@ -395,7 +394,6 @@ sub mkvcbuild
395394
$isolation_tester->AddIncludeDir('src\test\regress');
396395
$isolation_tester->AddIncludeDir('src\interfaces\libpq');
397396
$isolation_tester->AddDefine('HOST_TUPLE="i686-pc-win32vc"');
398-
$isolation_tester->AddDefine('FRONTEND');
399397
$isolation_tester->AddLibrary('ws2_32.lib');
400398
$isolation_tester->AddDirResourceFile('src\test\isolation');
401399
$isolation_tester->AddReference($libpq, $libpgcommon, $libpgport);
@@ -407,7 +405,6 @@ sub mkvcbuild
407405
$pgregress_isolation->AddIncludeDir('src\port');
408406
$pgregress_isolation->AddIncludeDir('src\test\regress');
409407
$pgregress_isolation->AddDefine('HOST_TUPLE="i686-pc-win32vc"');
410-
$pgregress_isolation->AddDefine('FRONTEND');
411408
$pgregress_isolation->AddLibrary('ws2_32.lib');
412409
$pgregress_isolation->AddDirResourceFile('src\test\isolation');
413410
$pgregress_isolation->AddReference($libpgcommon, $libpgport);
@@ -640,7 +637,6 @@ sub mkvcbuild
640637
$pgregress->AddFile('src\test\regress\pg_regress_main.c');
641638
$pgregress->AddIncludeDir('src\port');
642639
$pgregress->AddDefine('HOST_TUPLE="i686-pc-win32vc"');
643-
$pgregress->AddDefine('FRONTEND');
644640
$pgregress->AddLibrary('ws2_32.lib');
645641
$pgregress->AddDirResourceFile('src\test\regress');
646642
$pgregress->AddReference($libpgcommon, $libpgport);

0 commit comments

Comments
 (0)