Fix a couple of bugs in recent parallelism-related commits.

robertmhaas · robertmhaas · commit bde39eed0caf · 2015-10-22T10:49:20.000-04:00
Commit 816e336 added the wrong error check to async.c; sending restrictions is restricted to the leader, not altogether unsafe. Commit 3bd909b added ExecShutdownNode to traverse the planstate tree and call shutdown functions, but made a Gather node, the only node that actually has such a function, abort the tree traversal, which is wrong.
diff --git a/src/backend/commands/async.c b/src/backend/commands/async.c
@@ -117,6 +117,7 @@
 #include <unistd.h>
 #include <signal.h>
 
+#include "access/parallel.h"
 #include "access/slru.h"
 #include "access/transam.h"
 #include "access/xact.h"
@@ -544,8 +545,8 @@ Async_Notify(const char *channel, const char *payload)
 	Notification *n;
 	MemoryContext oldcontext;
 
-	if (IsInParallelMode())
-		elog(ERROR, "cannot send notifications during a parallel operation");
+	if (IsParallelWorker())
+		elog(ERROR, "cannot send notifications from a parallel worker");
 
 	if (Trace_notify)
 		elog(DEBUG1, "Async_Notify(%s)", channel);
diff --git a/src/backend/executor/execProcnode.c b/src/backend/executor/execProcnode.c
@@ -804,10 +804,7 @@ ExecShutdownNode(PlanState *node)
 	switch (nodeTag(node))
 	{
 		case T_GatherState:
-			{
-				ExecShutdownGather((GatherState *) node);
-				return true;
-			}
+			ExecShutdownGather((GatherState *) node);
 			break;
 		default:
 			break;
