pg_combinebackup: Message style improvements

petere · petere · commit c06100031102 · 2025-04-28T14:26:49.000+02:00
diff --git a/src/bin/pg_combinebackup/copy_file.c b/src/bin/pg_combinebackup/copy_file.c
@@ -330,7 +330,7 @@ copy_file_link(const char *src, const char *dest,
 			   pg_checksum_context *checksum_ctx)
 {
 	if (link(src, dest) < 0)
-		pg_fatal("error while linking file from \"%s\" to \"%s\": %m",
+		pg_fatal("could not create link from \"%s\" to \"%s\": %m",
 				 src, dest);
 
 	/* if needed, calculate checksum of the file */
diff --git a/src/bin/pg_combinebackup/pg_combinebackup.c b/src/bin/pg_combinebackup/pg_combinebackup.c
@@ -432,7 +432,7 @@ main(int argc, char *argv[])
 	/* Warn about the possibility of compromising the backups, when link mode */
 	if (opt.copy_method == COPY_METHOD_LINK)
 		pg_log_warning("--link mode was used; any modifications to the output "
-					   "directory may destructively modify input directories");
+					   "directory might destructively modify input directories");
 
 	/* It's a success, so don't remove the output directories. */
 	reset_directory_cleanup_list();

Original file line number	Diff line number	Diff line change
`@@ -330,7 +330,7 @@ copy_file_link(const char src, const char dest,`
`330`	`330`	`pg_checksum_context *checksum_ctx)`
`331`	`331`	`{`
`332`	`332`	`if (link(src, dest) < 0)`
`333`		`- pg_fatal("error while linking file from \"%s\" to \"%s\": %m",`
	`333`	`+ pg_fatal("could not create link from \"%s\" to \"%s\": %m",`
`334`	`334`	`src, dest);`
`335`	`335`
`336`	`336`	`/* if needed, calculate checksum of the file */`