Silence compiler warnings for unsupported compression methods.

tglsfdc · tglsfdc · commit c0d1c641cbe4 · 2022-04-08T18:14:24.000-04:00
wrasse, at least, moans about the lack of any "return" statement
in these functions.  You'd think pretty much everything would
know that exit(1) doesn't return, but evidently not.
diff --git a/src/bin/pg_basebackup/bbstreamer_gzip.c b/src/bin/pg_basebackup/bbstreamer_gzip.c
@@ -116,6 +116,7 @@ bbstreamer_gzip_writer_new(char *pathname, FILE *file,
 	return &streamer->base;
 #else
 	pg_fatal("this build does not support gzip compression");
+	return NULL;				/* keep compiler quiet */
 #endif
 }
 
@@ -248,6 +249,7 @@ bbstreamer_gzip_decompressor_new(bbstreamer *next)
 	return &streamer->base;
 #else
 	pg_fatal("this build does not support gzip compression");
+	return NULL;				/* keep compiler quiet */
 #endif
 }
 
diff --git a/src/bin/pg_basebackup/bbstreamer_lz4.c b/src/bin/pg_basebackup/bbstreamer_lz4.c
@@ -99,6 +99,7 @@ bbstreamer_lz4_compressor_new(bbstreamer *next, bc_specification *compress)
 	return &streamer->base;
 #else
 	pg_fatal("this build does not support lz4 compression");
+	return NULL;				/* keep compiler quiet */
 #endif
 }
 
@@ -296,6 +297,7 @@ bbstreamer_lz4_decompressor_new(bbstreamer *next)
 	return &streamer->base;
 #else
 	pg_fatal("this build does not support lz4 compression");
+	return NULL;				/* keep compiler quiet */
 #endif
 }
 
diff --git a/src/bin/pg_basebackup/bbstreamer_zstd.c b/src/bin/pg_basebackup/bbstreamer_zstd.c
@@ -117,6 +117,7 @@ bbstreamer_zstd_compressor_new(bbstreamer *next, bc_specification *compress)
 	return &streamer->base;
 #else
 	pg_fatal("this build does not support zstd compression");
+	return NULL;				/* keep compiler quiet */
 #endif
 }
 
@@ -271,6 +272,7 @@ bbstreamer_zstd_decompressor_new(bbstreamer *next)
 	return &streamer->base;
 #else
 	pg_fatal("this build does not support zstd compression");
+	return NULL;				/* keep compiler quiet */
 #endif
 }
 

Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,7 @@ bbstreamer_gzip_writer_new(char pathname, FILE file,`
`116`	`116`	`return &streamer->base;`
`117`	`117`	`#else`
`118`	`118`	`pg_fatal("this build does not support gzip compression");`
	`119`	`+ return NULL; /* keep compiler quiet */`
`119`	`120`	`#endif`
`120`	`121`	`}`
`121`	`122`
`@@ -248,6 +249,7 @@ bbstreamer_gzip_decompressor_new(bbstreamer *next)`
`248`	`249`	`return &streamer->base;`
`249`	`250`	`#else`
`250`	`251`	`pg_fatal("this build does not support gzip compression");`
	`252`	`+ return NULL; /* keep compiler quiet */`
`251`	`253`	`#endif`
`252`	`254`	`}`
`253`	`255`
Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,7 @@ bbstreamer_lz4_compressor_new(bbstreamer next, bc_specification compress)`
`99`	`99`	`return &streamer->base;`
`100`	`100`	`#else`
`101`	`101`	`pg_fatal("this build does not support lz4 compression");`
	`102`	`+ return NULL; /* keep compiler quiet */`
`102`	`103`	`#endif`
`103`	`104`	`}`
`104`	`105`
`@@ -296,6 +297,7 @@ bbstreamer_lz4_decompressor_new(bbstreamer *next)`
`296`	`297`	`return &streamer->base;`
`297`	`298`	`#else`
`298`	`299`	`pg_fatal("this build does not support lz4 compression");`
	`300`	`+ return NULL; /* keep compiler quiet */`
`299`	`301`	`#endif`
`300`	`302`	`}`
`301`	`303`
Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,7 @@ bbstreamer_zstd_compressor_new(bbstreamer next, bc_specification compress)`
`117`	`117`	`return &streamer->base;`
`118`	`118`	`#else`
`119`	`119`	`pg_fatal("this build does not support zstd compression");`
	`120`	`+ return NULL; /* keep compiler quiet */`
`120`	`121`	`#endif`
`121`	`122`	`}`
`122`	`123`
`@@ -271,6 +272,7 @@ bbstreamer_zstd_decompressor_new(bbstreamer *next)`
`271`	`272`	`return &streamer->base;`
`272`	`273`	`#else`
`273`	`274`	`pg_fatal("this build does not support zstd compression");`
	`275`	`+ return NULL; /* keep compiler quiet */`
`274`	`276`	`#endif`
`275`	`277`	`}`
`276`	`278`