Here's a tiny fix for a harmless typo in catalog.c:

Neil Conway · Neil Conway · commit c6ad5c2eb4c3 · 2005-03-07T04:15:34.000Z
Too much space is allocated for tablespace file path, I guess the
directory name used to be "pg_tablespaces" instead of "pg_tblspc" at
some point.

Heikki Linnakangas
diff --git a/src/backend/catalog/catalog.c b/src/backend/catalog/catalog.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/catalog/catalog.c,v 1.57 2004/12/31 21:59:38 pgsql Exp $
+ *	  $PostgreSQL: pgsql/src/backend/catalog/catalog.c,v 1.58 2005/03/07 04:15:34 neilc Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -58,7 +58,7 @@ relpath(RelFileNode rnode)
 	else
 	{
 		/* All other tablespaces are accessed via symlinks */
-		pathlen = strlen(DataDir) + 16 + OIDCHARS + 1 + OIDCHARS + 1 + OIDCHARS + 1;
+		pathlen = strlen(DataDir) + 11 + OIDCHARS + 1 + OIDCHARS + 1 + OIDCHARS + 1;
 		path = (char *) palloc(pathlen);
 		snprintf(path, pathlen, "%s/pg_tblspc/%u/%u/%u",
 				 DataDir, rnode.spcNode, rnode.dbNode, rnode.relNode);
@@ -99,7 +99,7 @@ GetDatabasePath(Oid dbNode, Oid spcNode)
 	else
 	{
 		/* All other tablespaces are accessed via symlinks */
-		pathlen = strlen(DataDir) + 16 + OIDCHARS + 1 + OIDCHARS + 1;
+		pathlen = strlen(DataDir) + 11 + OIDCHARS + 1 + OIDCHARS + 1;
 		path = (char *) palloc(pathlen);
 		snprintf(path, pathlen, "%s/pg_tblspc/%u/%u",
 				 DataDir, spcNode, dbNode);

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $PostgreSQL: pgsql/src/backend/catalog/catalog.c,v 1.57 2004/12/31 21:59:38 pgsql Exp $`
	`12`	`+ * $PostgreSQL: pgsql/src/backend/catalog/catalog.c,v 1.58 2005/03/07 04:15:34 neilc Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -58,7 +58,7 @@ relpath(RelFileNode rnode)`
`58`	`58`	`else`
`59`	`59`	`{`
`60`	`60`	`/* All other tablespaces are accessed via symlinks */`
`61`		`- pathlen = strlen(DataDir) + 16 + OIDCHARS + 1 + OIDCHARS + 1 + OIDCHARS + 1;`
	`61`	`+ pathlen = strlen(DataDir) + 11 + OIDCHARS + 1 + OIDCHARS + 1 + OIDCHARS + 1;`
`62`	`62`	`path = (char *) palloc(pathlen);`
`63`	`63`	`snprintf(path, pathlen, "%s/pg_tblspc/%u/%u/%u",`
`64`	`64`	`DataDir, rnode.spcNode, rnode.dbNode, rnode.relNode);`
`@@ -99,7 +99,7 @@ GetDatabasePath(Oid dbNode, Oid spcNode)`
`99`	`99`	`else`
`100`	`100`	`{`
`101`	`101`	`/* All other tablespaces are accessed via symlinks */`
`102`		`- pathlen = strlen(DataDir) + 16 + OIDCHARS + 1 + OIDCHARS + 1;`
	`102`	`+ pathlen = strlen(DataDir) + 11 + OIDCHARS + 1 + OIDCHARS + 1;`
`103`	`103`	`path = (char *) palloc(pathlen);`
`104`	`104`	`snprintf(path, pathlen, "%s/pg_tblspc/%u/%u",`
`105`	`105`	`DataDir, spcNode, dbNode);`