Remove gratuitous assumptions about what make_modifytable can see.

tglsfdc · tglsfdc · commit c6c3b3bc3de1 · 2023-02-20T12:06:30.000-05:00
For no clearly good reason, make_modifytable assumed that it could not reach its get-the-FDW-info-the-hard-way path in MERGE. It's currently possible to demonstrate that assertion failing, which seems to be due to an upstream planner bug; but there's no good reason to do it like this at all. Let's apply the principle of separation of concerns and make the MERGE check separately, after getting or not getting the fdwroutine pointer. Per report from Alexander Lakhin. No test case, since I think the potential test condition will go away soon. Discussion: https://postgr.es/m/36bee393-b351-16ac-93b2-d46d83637e45@gmail.com
diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.c
@@ -7093,38 +7093,36 @@ make_modifytable(PlannerInfo *root, Plan *subplan,
 			RelOptInfo *resultRel = root->simple_rel_array[rti];
 
 			fdwroutine = resultRel->fdwroutine;
-
-			/*
-			 * MERGE is not currently supported for foreign tables and we
-			 * already checked when the table mentioned in the query is
-			 * foreign; but we can still get here if a partitioned table has a
-			 * foreign table as partition.  Disallow that now, to avoid an
-			 * uglier error message later.
-			 */
-			if (operation == CMD_MERGE && fdwroutine != NULL)
-			{
-				RangeTblEntry *rte = root->simple_rte_array[rti];
-
-				ereport(ERROR,
-						errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-						errmsg("cannot execute MERGE on relation \"%s\"",
-							   get_rel_name(rte->relid)),
-						errdetail_relkind_not_supported(rte->relkind));
-			}
-
 		}
 		else
 		{
 			RangeTblEntry *rte = planner_rt_fetch(rti, root);
 
-			Assert(rte->rtekind == RTE_RELATION);
-			Assert(operation != CMD_MERGE);
-			if (rte->relkind == RELKIND_FOREIGN_TABLE)
+			if (rte->rtekind == RTE_RELATION &&
+				rte->relkind == RELKIND_FOREIGN_TABLE)
 				fdwroutine = GetFdwRoutineByRelId(rte->relid);
 			else
 				fdwroutine = NULL;
 		}
 
+		/*
+		 * MERGE is not currently supported for foreign tables.  We already
+		 * checked that when the table mentioned in the query is foreign; but
+		 * we can still get here if a partitioned table has a foreign table as
+		 * partition.  Disallow that now, to avoid an uglier error message
+		 * later.
+		 */
+		if (operation == CMD_MERGE && fdwroutine != NULL)
+		{
+			RangeTblEntry *rte = planner_rt_fetch(rti, root);
+
+			ereport(ERROR,
+					errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
+					errmsg("cannot execute MERGE on relation \"%s\"",
+						   get_rel_name(rte->relid)),
+					errdetail_relkind_not_supported(rte->relkind));
+		}
+
 		/*
 		 * Try to modify the foreign table directly if (1) the FDW provides
 		 * callback functions needed for that and (2) there are no local
