Fix misplaced const

petere · petere · commit c8c885b7a5c8 · 2019-03-26T09:23:08.000+01:00
These instances were apparently trying to carry the const qualifier
from the arguments through the complex casts, but for that the const
qualifier was misplaced.
diff --git a/src/backend/partitioning/partbounds.c b/src/backend/partitioning/partbounds.c
@@ -1684,8 +1684,8 @@ qsort_partition_hbound_cmp(const void *a, const void *b)
 static int32
 qsort_partition_list_value_cmp(const void *a, const void *b, void *arg)
 {
-	Datum		val1 = (*(const PartitionListValue **) a)->value,
-				val2 = (*(const PartitionListValue **) b)->value;
+	Datum		val1 = (*(PartitionListValue *const *) a)->value,
+				val2 = (*(PartitionListValue *const *) b)->value;
 	PartitionKey key = (PartitionKey) arg;
 
 	return DatumGetInt32(FunctionCall2Coll(&key->partsupfunc[0],
diff --git a/src/backend/utils/adt/tsquery_op.c b/src/backend/utils/adt/tsquery_op.c
@@ -296,8 +296,8 @@ collectTSQueryValues(TSQuery a, int *nvalues_p)
 static int
 cmp_string(const void *a, const void *b)
 {
-	const char *sa = *((const char **) a);
-	const char *sb = *((const char **) b);
+	const char *sa = *((char *const *) a);
+	const char *sb = *((char *const *) b);
 
 	return strcmp(sa, sb);
 }

Original file line number	Diff line number	Diff line change
`@@ -296,8 +296,8 @@ collectTSQueryValues(TSQuery a, int *nvalues_p)`
`296`	`296`	`static int`
`297`	`297`	`cmp_string(const void a, const void b)`
`298`	`298`	`{`
`299`		`- const char sa = ((const char **) a);`
`300`		`- const char sb = ((const char **) b);`
	`299`	`+ const char sa = ((char const ) a);`
	`300`	`+ const char sb = ((char const ) b);`
`301`	`301`
`302`	`302`	`return strcmp(sa, sb);`
`303`	`303`	`}`