Remove overzealous VACUUM visibility map assertion.

petergeoghegan · petergeoghegan · commit c9787385db47 · 2021-05-06T13:17:39.000-07:00
The all_visible_according_to_vm variable's value is inherently prone to becoming invalidated concurrently, since it is set before we even acquire a lock on a related heap page buffer. Oversight in commit 7136bf3, which added the assertion in passing. Author: Masahiko Sawada <sawada.mshk@gmail.com> Reported-By: Tang <tanghy.fnst@fujitsu.com> Diagnosed-By:: Masahiko Sawada <sawada.mshk@gmail.com> Discussion: https://postgr.es/m/CAD21AoDzgc8_MYrA5m1fyydomw_eVKtQiYh7sfDK4KEhdMsf_g@mail.gmail.com
diff --git a/src/backend/access/heap/vacuumlazy.c b/src/backend/access/heap/vacuumlazy.c
@@ -1344,7 +1344,6 @@ lazy_scan_heap(LVRelState *vacrel, VacuumParams *params, bool aggressive)
 		lazy_scan_prune(vacrel, buf, blkno, page, vistest, &prunestate);
 
 		Assert(!prunestate.all_visible || !prunestate.has_lpdead_items);
-		Assert(!all_visible_according_to_vm || prunestate.all_visible);
 
 		/* Remember the location of the last page with nonremovable tuples */
 		if (prunestate.hastup)
