Improve errhint() about replication slot naming restrictions.

anarazel · anarazel · commit cfddb5df5a84 · 2015-10-03T15:29:35.000+02:00
The existing hint talked about "may only contain letters", but the
actual requirement is more strict: only lower case letters are allowed.

Reported-By: Rushabh Lathia
Author: Rushabh Lathia
Discussion: AGPqQf2x50qcwbYOBKzb4x75sO_V3g81ZsA8+Ji9iN5t_khFhQ@mail.gmail.com
Backpatch: 9.4-, where replication slots were added
diff --git a/contrib/test_decoding/expected/ddl.out b/contrib/test_decoding/expected/ddl.out
@@ -12,7 +12,7 @@ ERROR:  replication slot "regression_slot" already exists
 -- fail because of an invalid name
 SELECT 'init' FROM pg_create_logical_replication_slot('Invalid Name', 'test_decoding');
 ERROR:  replication slot name "Invalid Name" contains invalid character
-HINT:  Replication slot names may only contain letters, numbers, and the underscore character.
+HINT:  Replication slot names may only contain lower case letters, numbers, and the underscore character.
 -- fail twice because of an invalid parameter values
 SELECT 'init' FROM pg_logical_slot_get_changes('regression_slot', NULL, NULL, 'include-xids', 'frakbar');
 ERROR:  could not parse value "frakbar" for parameter "include-xids"
diff --git a/src/backend/replication/slot.c b/src/backend/replication/slot.c
@@ -195,7 +195,7 @@ ReplicationSlotValidateName(const char *name, int elevel)
 					(errcode(ERRCODE_INVALID_NAME),
 			errmsg("replication slot name \"%s\" contains invalid character",
 				   name),
-					 errhint("Replication slot names may only contain letters, numbers, and the underscore character.")));
+					 errhint("Replication slot names may only contain lower case letters, numbers, and the underscore character.")));
 			return false;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -195,7 +195,7 @@ ReplicationSlotValidateName(const char *name, int elevel)`
`195`	`195`	`(errcode(ERRCODE_INVALID_NAME),`
`196`	`196`	`errmsg("replication slot name \"%s\" contains invalid character",`
`197`	`197`	`name),`
`198`		`- errhint("Replication slot names may only contain letters, numbers, and the underscore character.")));`
	`198`	`+ errhint("Replication slot names may only contain lower case letters, numbers, and the underscore character.")));`
`199`	`199`	`return false;`
`200`	`200`	`}`
`201`	`201`	`}`