Fix uninitialized-memory bug in plpython proargnames patch. Per bug #3523

tglsfdc · tglsfdc · commit d0e5c0c0eeec · 2007-08-10T03:16:04.000Z
diff --git a/src/pl/plpython/plpython.c b/src/pl/plpython/plpython.c
@@ -1,7 +1,7 @@
 /**********************************************************************
  * plpython.c - python as a procedural language for PostgreSQL
  *
- *	$PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.102 2007/07/13 04:57:59 tgl Exp $
+ *	$PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.103 2007/08/10 03:16:04 tgl Exp $
  *
  *********************************************************************
  */
@@ -1259,6 +1259,7 @@ PLy_procedure_create(FunctionCallInfo fcinfo, Oid tgreloid,
 						 "proargnames must have the same number of elements "
 						 "as the function has arguments");
 				proc->argnames = (char **) PLy_malloc(sizeof(char *) * proc->nargs);
+				memset(proc->argnames, 0, sizeof(char *) * proc->nargs);
 			}
 		}
 		for (i = 0; i < fcinfo->nargs; i++)

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/**********************************************************************`
`2`	`2`	`* plpython.c - python as a procedural language for PostgreSQL`
`3`	`3`	`*`
`4`		`- * $PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.102 2007/07/13 04:57:59 tgl Exp $`
	`4`	`+ * $PostgreSQL: pgsql/src/pl/plpython/plpython.c,v 1.103 2007/08/10 03:16:04 tgl Exp $`
`5`	`5`	`*`
`6`	`6`	`*********************************************************************`
`7`	`7`	`*/`
`@@ -1259,6 +1259,7 @@ PLy_procedure_create(FunctionCallInfo fcinfo, Oid tgreloid,`
`1259`	`1259`	`"proargnames must have the same number of elements "`
`1260`	`1260`	`"as the function has arguments");`
`1261`	`1261`	`proc->argnames = (char *) PLy_malloc(sizeof(char ) * proc->nargs);`
	`1262`	`+ memset(proc->argnames, 0, sizeof(char ) proc->nargs);`
`1262`	`1263`	`}`
`1263`	`1264`	`}`
`1264`	`1265`	`for (i = 0; i < fcinfo->nargs; i++)`