Fix unportable usage of <ctype.h> functions.

tglsfdc · tglsfdc · commit d1f9ac5b100d · 2017-11-07T13:49:36.000-05:00
isdigit(), isspace(), etc are likely to give surprising results if passed a signed char. We should always cast the argument to unsigned char to avoid that. Error in commit 63d6b97, found by buildfarm member gaur. Back-patch to 9.3, like that commit.
diff --git a/src/interfaces/ecpg/ecpglib/data.c b/src/interfaces/ecpg/ecpglib/data.c
@@ -57,7 +57,7 @@ garbage_left(enum ARRAY_TYPE isarray, char **scan_length, enum COMPAT_MODE compa
 			/* skip invalid characters */
 			do {
 				(*scan_length)++;
-			} while (isdigit(**scan_length));
+			} while (isdigit((unsigned char) **scan_length));
 		}
 
 		if (**scan_length != ' ' && **scan_length != '\0')

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ garbage_left(enum ARRAY_TYPE isarray, char **scan_length, enum COMPAT_MODE compa`
`57`	`57`	`/* skip invalid characters */`
`58`	`58`	`do {`
`59`	`59`	`(*scan_length)++;`
`60`		`- } while (isdigit(**scan_length));`
	`60`	`+ } while (isdigit((unsigned char) **scan_length));`
`61`	`61`	`}`
`62`	`62`
`63`	`63`	`if (scan_length != ' ' && scan_length != '\0')`