Remove assertion in pgstat_count_io_op()

michaelpq · michaelpq · commit d2181b321852 · 2025-01-14T12:19:51.000+09:00
An equivalent check is done with pgstat_is_ioop_tracked_in_bytes(), so there is no need for this extra one. Small cleanup that should have been included in f92c854. Author: Nazir Bilal Yavuz Reviewed-by: Bertrand Drouvot Discussion: https://postgr.es/m/CAN55FZ0oqxBaaHAEsj=xFqkzE3n5P=3RA1V_igXwL-RV7QRzyw@mail.gmail.com
diff --git a/src/backend/utils/activity/pgstat_io.c b/src/backend/utils/activity/pgstat_io.c
@@ -78,7 +78,6 @@ pgstat_count_io_op(IOObject io_object, IOContext io_context, IOOp io_op,
 {
 	Assert((unsigned int) io_object < IOOBJECT_NUM_TYPES);
 	Assert((unsigned int) io_context < IOCONTEXT_NUM_TYPES);
-	Assert((unsigned int) io_op < IOOP_NUM_TYPES);
 	Assert(pgstat_is_ioop_tracked_in_bytes(io_op) || bytes == 0);
 	Assert(pgstat_tracks_io_op(MyBackendType, io_object, io_context, io_op));
 

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,6 @@ pgstat_count_io_op(IOObject io_object, IOContext io_context, IOOp io_op,`
`78`	`78`	`{`
`79`	`79`	`Assert((unsigned int) io_object < IOOBJECT_NUM_TYPES);`
`80`	`80`	`Assert((unsigned int) io_context < IOCONTEXT_NUM_TYPES);`
`81`		`- Assert((unsigned int) io_op < IOOP_NUM_TYPES);`
`82`	`81`	`Assert(pgstat_is_ioop_tracked_in_bytes(io_op) \|\| bytes == 0);`
`83`	`82`	`Assert(pgstat_tracks_io_op(MyBackendType, io_object, io_context, io_op));`
`84`	`83`