SELECT ... FOR UPDATE neglects duplicate key checking.

tatsuo-ishii · tatsuo-ishii · commit daee6ca5853d · 2000-07-26T13:09:30.000Z
patches submitted by Hiroshi Inoue.
diff --git a/src/backend/utils/time/tqual.c b/src/backend/utils/time/tqual.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/time/tqual.c,v 1.35 2000/01/26 05:57:36 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/time/tqual.c,v 1.35.2.1 2000/07/26 13:09:30 ishii Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -441,7 +441,11 @@ HeapTupleSatisfiesDirty(HeapTupleHeader tuple)
 	}
 
 	if (TransactionIdIsCurrentTransactionId(tuple->t_xmax))
+	{
+		if (tuple->t_infomask & HEAP_MARKED_FOR_UPDATE)
+			return true;
 		return false;
+	}
 
 	if (!TransactionIdDidCommit(tuple->t_xmax))
 	{

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/utils/time/tqual.c,v 1.35 2000/01/26 05:57:36 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/time/tqual.c,v 1.35.2.1 2000/07/26 13:09:30 ishii Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -441,7 +441,11 @@ HeapTupleSatisfiesDirty(HeapTupleHeader tuple)`
`441`	`441`	`}`
`442`	`442`
`443`	`443`	`if (TransactionIdIsCurrentTransactionId(tuple->t_xmax))`
	`444`	`+ {`
	`445`	`+ if (tuple->t_infomask & HEAP_MARKED_FOR_UPDATE)`
	`446`	`+ return true;`
`444`	`447`	`return false;`
	`448`	`+ }`
`445`	`449`
`446`	`450`	`if (!TransactionIdDidCommit(tuple->t_xmax))`
`447`	`451`	`{`