Remove hard-coded "\connect postgres" from pg_dumpall.

robertmhaas · robertmhaas · commit deb158032498 · 2011-10-28T15:50:42.000-04:00
This doesn't appear to accompish anything useful, and does make the
restore fail if the postgres database happens to have been dropped.
diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
@@ -441,7 +441,12 @@ main(int argc, char *argv[])
 	if (verbose)
 		dumpTimestamp("Started on");
 
-	fprintf(OPF, "\\connect postgres\n\n");
+	/*
+	 * We used to emit \connect postgres here, but that served no purpose
+	 * other than to break things for installations without a postgres
+	 * database.  Everything we're restoring here is a global, so whichever
+	 * database we're connected to at the moment is fine.
+	 */
 
 	/* Replicate encoding and std_strings in output */
 	fprintf(OPF, "SET client_encoding = '%s';\n",
