Skip to content

Commit e148009

Browse files
committed
Remove ICU tests from default run
These tests require the test database to be in UTF8 encoding. Until there is a better solution, take them out of the default test set and treat them like the existing collate.linux.utf8 test, meaning it has to be selected manually.
1 parent cd07f73 commit e148009

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

doc/src/sgml/regress.sgml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -264,10 +264,12 @@ make check EXTRA_TESTS=numeric_big
264264
</screen>
265265
To run the collation tests:
266266
<screen>
267-
make check EXTRA_TESTS=collate.linux.utf8 LANG=en_US.utf8
267+
make check EXTRA_TESTS='collate.icu.utf8 collate.linux.utf8' LANG=en_US.utf8
268268
</screen>
269269
The <literal>collate.linux.utf8</> test works only on Linux/glibc
270-
platforms, and only when run in a database that uses UTF-8 encoding.
270+
platforms. The <literal>collate.icu.utf8</literal> test only works when
271+
support for ICU was built. Both tests will only succeed when run in a
272+
database that uses UTF-8 encoding.
271273
</para>
272274
</sect2>
273275

src/test/regress/GNUmakefile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,6 @@ tablespace-setup:
125125
##
126126

127127
REGRESS_OPTS = --dlpath=. $(EXTRA_REGRESS_OPTS)
128-
ifeq ($(with_icu),yes)
129-
override EXTRA_TESTS := collate.icu $(EXTRA_TESTS)
130-
endif
131128

132129
check: all tablespace-setup
133130
$(pg_regress_check) $(REGRESS_OPTS) --schedule=$(srcdir)/parallel_schedule $(MAXCONNOPT) $(EXTRA_TESTS)

0 commit comments

Comments
 (0)