Fix possible corruption of AfterTriggerEventLists in subtransaction rollback.

tglsfdc · tglsfdc · commit e275d16a54de · 2010-08-19T15:46:18.000Z
afterTriggerInvokeEvents failed to adjust events-&gt;tailfree when truncating
the last chunk of an event list.  This could result in the data being
"de-truncated" by afterTriggerRestoreEventList during a subsequent
subtransaction abort.  Even that wouldn't kill us, because the re-added data
would just be events marked DONE --- unless the data had been partially
overwritten by new events.  Then we might crash, or in any case misbehave
(perhaps fire triggers twice, or fire triggers with the wrong event data).
Per bug #5622 from Thue Janus Kristensen.

Back-patch to 8.4 where the current trigger list representation was introduced.
diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/trigger.c,v 1.264 2010/08/05 15:25:35 rhaas Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/trigger.c,v 1.265 2010/08/19 15:46:18 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -2955,6 +2955,7 @@ afterTriggerAddEvent(AfterTriggerEventList *events,
 		else
 			events->tail->next = chunk;
 		events->tail = chunk;
+		/* events->tailfree is now out of sync, but we'll fix it below */
 	}
 
 	/*
@@ -3356,6 +3357,15 @@ afterTriggerInvokeEvents(AfterTriggerEventList *events,
 		{
 			chunk->freeptr = CHUNK_DATA_START(chunk);
 			chunk->endfree = chunk->endptr;
+
+			/*
+			 * If it's last chunk, must sync event list's tailfree too.  Note
+			 * that delete_ok must NOT be passed as true if there could be
+			 * stacked AfterTriggerEventList values pointing at this event
+			 * list, since we'd fail to fix their copies of tailfree.
+			 */
+			if (chunk == events->tail)
+				events->tailfree = chunk->freeptr;
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1994, Regents of the University of California`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $PostgreSQL: pgsql/src/backend/commands/trigger.c,v 1.264 2010/08/05 15:25:35 rhaas Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/commands/trigger.c,v 1.265 2010/08/19 15:46:18 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -2955,6 +2955,7 @@ afterTriggerAddEvent(AfterTriggerEventList *events,`
`2955`	`2955`	`else`
`2956`	`2956`	`events->tail->next = chunk;`
`2957`	`2957`	`events->tail = chunk;`
	`2958`	`+ /* events->tailfree is now out of sync, but we'll fix it below */`
`2958`	`2959`	`}`
`2959`	`2960`
`2960`	`2961`	`/*`
`@@ -3356,6 +3357,15 @@ afterTriggerInvokeEvents(AfterTriggerEventList *events,`
`3356`	`3357`	`{`
`3357`	`3358`	`chunk->freeptr = CHUNK_DATA_START(chunk);`
`3358`	`3359`	`chunk->endfree = chunk->endptr;`
	`3360`	`+`
	`3361`	`+ /*`
	`3362`	`+ * If it's last chunk, must sync event list's tailfree too. Note`
	`3363`	`+ * that delete_ok must NOT be passed as true if there could be`
	`3364`	`+ * stacked AfterTriggerEventList values pointing at this event`
	`3365`	`+ * list, since we'd fail to fix their copies of tailfree.`
	`3366`	`+ */`
	`3367`	`+ if (chunk == events->tail)`
	`3368`	`+ events->tailfree = chunk->freeptr;`
`3359`	`3369`	`}`
`3360`	`3370`	`}`
`3361`	`3371`