Suppress remaining -Waddress warnings from recent gcc versions.

tglsfdc · tglsfdc · commit e331c60ea727 · 2011-10-18T21:44:23.000-04:00
Still an exercise in satisfying pedants.
diff --git a/src/bin/psql/psqlscan.l b/src/bin/psql/psqlscan.l
@@ -1673,7 +1673,7 @@ evaluate_backtick(void)
 		error = true;
 	}
 
-	if (PQExpBufferBroken(&cmd_output))
+	if (PQExpBufferDataBroken(cmd_output))
 	{
 		psql_error("%s: out of memory\n", cmd);
 		error = true;
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
@@ -829,7 +829,7 @@ PQconndefaults(void)
 	PQconninfoOption *connOptions;
 
 	initPQExpBuffer(&errorBuf);
-	if (PQExpBufferBroken(&errorBuf))
+	if (PQExpBufferDataBroken(errorBuf))
 		return NULL;			/* out of memory already :-( */
 	connOptions = conninfo_parse("", &errorBuf, true);
 	termPQExpBuffer(&errorBuf);
@@ -3967,7 +3967,7 @@ PQconninfoParse(const char *conninfo, char **errmsg)
 	if (errmsg)
 		*errmsg = NULL;			/* default */
 	initPQExpBuffer(&errorBuf);
-	if (PQExpBufferBroken(&errorBuf))
+	if (PQExpBufferDataBroken(errorBuf))
 		return NULL;			/* out of memory already :-( */
 	connOptions = conninfo_parse(conninfo, &errorBuf, false);
 	if (connOptions == NULL && errmsg)
diff --git a/src/interfaces/libpq/pqexpbuffer.h b/src/interfaces/libpq/pqexpbuffer.h
@@ -59,6 +59,14 @@ typedef PQExpBufferData *PQExpBuffer;
 #define PQExpBufferBroken(str)	\
 	((str) == NULL || (str)->maxlen == 0)
 
+/*------------------------
+ * Same, but for use when using a static or local PQExpBufferData struct.
+ * For that, a null-pointer test is useless and may draw compiler warnings.
+ *------------------------
+ */
+#define PQExpBufferDataBroken(buf)	\
+	((buf).maxlen == 0)
+
 /*------------------------
  * Initial size of the data buffer in a PQExpBuffer.
  * NB: this must be large enough to hold error messages that might

Original file line number	Diff line number	Diff line change
`@@ -1673,7 +1673,7 @@ evaluate_backtick(void)`
`1673`	`1673`	`error = true;`
`1674`	`1674`	`}`
`1675`	`1675`
`1676`		`- if (PQExpBufferBroken(&cmd_output))`
	`1676`	`+ if (PQExpBufferDataBroken(cmd_output))`
`1677`	`1677`	`{`
`1678`	`1678`	`psql_error("%s: out of memory\n", cmd);`
`1679`	`1679`	`error = true;`