Comment on expectations for AutoVacuumWorkItem handlers.

nmisch · nmisch · commit e33967b13bbc · 2023-03-25T13:00:27.000-07:00
This might prevent a repeat of the brin_summarize_range() vulnerability that commit a117ceb fixed.
diff --git a/src/backend/postmaster/autovacuum.c b/src/backend/postmaster/autovacuum.c
@@ -2655,7 +2655,10 @@ perform_work_item(AutoVacuumWorkItem *workitem)
 		/* Use PortalContext for any per-work-item allocations */
 		MemoryContextSwitchTo(PortalContext);
 
-		/* have at it */
+		/*
+		 * Have at it.  Functions called here are responsible for any required
+		 * user switch and sandbox.
+		 */
 		switch (workitem->avw_type)
 		{
 			case AVW_BRINSummarizeRange:
