Skip to content

Commit e52a44b

Browse files
macdicemacdice
committed
Skip citext_utf8 test on Windows.
Back-patch of commit cff4e5a to 15 and 16, per request from Oleg Tselebrovskiy. Original commit message: On other Windows build farm animals it is already skipped because they don't use UTF-8 encoding. On "hamerkop", UTF-8 is used, and then the test fails. It is not clear to me (a non-Windows person looking only at buildfarm evidence) whether Windows is less sophisticated than other OSes and doesn't know how to downcase Turkish İ with the standard Unicode database, or if it is more sophisticated than other systems and uses locale-specific behavior like ICU does. Whichever the reason, the result is the same: we need to skip the test on Windows, just as we already do for ICU, at least until a Windows-savvy developer comes up with a better idea. The technique for detecting the OS is borrowed from collate.windows.win1252.sql. This was anticipated by commit c2e8bd2, but the problem only surfaced when Windows build farm animals started using Meson. Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/CA%2BhUKGJ1LeC3aE2qQYTK95rFVON3ZVoTQpTKJqxkHdtEyawH4A%40mail.gmail.com
1 parent d7bc9c9 commit e52a44b

File tree

3 files changed

+3
-0
lines changed

3 files changed

+3
-0
lines changed

‎contrib/citext/expected/citext_utf8.out

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* and a Unicode-aware locale.
44
*/
55
SELECT getdatabaseencoding() <> 'UTF8' OR
6+
version() ~ '(Visual C\+\+|mingw32|windows)' OR
67
current_setting('lc_ctype') = 'C'
78
AS skip_test \gset
89
\if :skip_test

‎contrib/citext/expected/citext_utf8_1.out

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* and a Unicode-aware locale.
44
*/
55
SELECT getdatabaseencoding() <> 'UTF8' OR
6+
version() ~ '(Visual C\+\+|mingw32|windows)' OR
67
current_setting('lc_ctype') = 'C'
78
AS skip_test \gset
89
\if :skip_test

‎contrib/citext/sql/citext_utf8.sql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
*/
55

66
SELECT getdatabaseencoding() <> 'UTF8' OR
7+
version() ~ '(Visual C\+\+|mingw32|windows)' OR
78
current_setting('lc_ctype') = 'C'
89
AS skip_test \gset
910
\if :skip_test

0 commit comments

Comments
 (0)