Skip to content

Commit eac0a6c

Browse files
tglsfdctglsfdc
committed
Avoid locale-dependent output in select_views regression test.
Use 'COLLATE "C"' to force locale-independent sorting of the iexit view results in select_views.sql. We aren't particularly interested in the exact sorting behavior here, and this doesn't change the shape of the generated plan, so it seems like a wash as far as the goals of this test go. This is in response to bug #14637 from Tomasz Kontusz. It doesn't fully resolve his problem, because he also saw some diffs in the create_index test. But other people have had issues with select_views too, and this fix lets us drop the select_views_1.out variant expected file altogether, which is a nice win from a maintenance standpoint. Emre Hasegeli Discussion: https://postgr.es/m/20170501000609.24360.24248@wrigleys.postgresql.org
1 parent 764cb2b commit eac0a6c

File tree

3 files changed

+2
-1554
lines changed

3 files changed

+2
-1554
lines changed

‎src/test/regress/expected/select_views.out

+1-1
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ SELECT * FROM street;
340340
98th Ave | [(-122.2001,37.258),(-122.1974,37.27)] | Lafayette
341341
(333 rows)
342342

343-
SELECT name, #thepath FROM iexit ORDER BY 1, 2;
343+
SELECT name, #thepath FROM iexit ORDER BY name COLLATE "C", 2;
344344
name | ?column?
345345
------------------------------------+----------
346346
I- 580 | 2

0 commit comments

Comments
 (0)