Skip to content

Commit eb43f3d

Browse files
michaelpqmichaelpq
committed
Fix inconsistencies and typos in the tree
This is numbered take 8, and addresses again a set of issues with code comments, variable names and unreferenced variables. Author: Alexander Lakhin Discussion: https://postgr.es/m/b137b5eb-9c95-9c2f-586e-38aba7d59788@gmail.com
1 parent 7cce159 commit eb43f3d

File tree

42 files changed

+58
-75
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+58
-75
lines changed

‎contrib/pgcrypto/pgp-decrypt.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ mdc_finish(PGP_Context *ctx, PullFilter *src, int len)
355355
if (len != 20)
356356
return PXE_PGP_CORRUPT_DATA;
357357

358-
/* mdc_read should not call md_update */
358+
/* mdc_read should not call px_md_update */
359359
ctx->in_mdc_pkt = 1;
360360

361361
/* read data */

‎doc/src/sgml/custom-scan.sgml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,7 @@ typedef struct CustomPath
8383
by <literal>nodeToString</literal>, so that debugging routines that attempt to
8484
print the custom path will work as designed. <structfield>methods</structfield> must
8585
point to a (usually statically allocated) object implementing the required
86-
custom path methods, of which there is currently only one. The
87-
<structfield>LibraryName</structfield> and <structfield>SymbolName</structfield> fields must also
88-
be initialized so that the dynamic loader can resolve them to locate the
89-
method table.
86+
custom path methods, of which there is currently only one.
9087
</para>
9188

9289
<para>

‎doc/src/sgml/ref/create_aggregate.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ CREATE [ OR REPLACE ] AGGREGATE <replaceable class="parameter">name</replaceable
211211
as described in <xref linkend="xaggr-moving-aggregates"/>. This requires
212212
specifying the <literal>MSFUNC</literal>, <literal>MINVFUNC</literal>,
213213
and <literal>MSTYPE</literal> parameters, and optionally
214-
the <literal>MSPACE</literal>, <literal>MFINALFUNC</literal>,
214+
the <literal>MSSPACE</literal>, <literal>MFINALFUNC</literal>,
215215
<literal>MFINALFUNC_EXTRA</literal>, <literal>MFINALFUNC_MODIFY</literal>,
216216
and <literal>MINITCOND</literal> parameters. Except for <literal>MINVFUNC</literal>,
217217
these parameters work like the corresponding simple-aggregate parameters

‎doc/src/sgml/xplang.sgml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ CREATE FUNCTION <replaceable>validator_function_name</replaceable>(oid)
137137
<para>
138138
Finally, the PL must be declared with the command
139139
<synopsis>
140-
CREATE <optional>TRUSTED</optional> LANGUAGE <replaceable>language-name</replaceable>
140+
CREATE <optional>TRUSTED</optional> LANGUAGE <replaceable>language_name</replaceable>
141141
HANDLER <replaceable>handler_function_name</replaceable>
142142
<optional>INLINE <replaceable>inline_function_name</replaceable></optional>
143143
<optional>VALIDATOR <replaceable>validator_function_name</replaceable></optional> ;

‎src/Makefile.global.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ standard_targets = all install installdirs uninstall distprep clean distclean ma
2323
# these targets should recurse even into subdirectories not being built:
2424
standard_always_targets = distprep clean distclean maintainer-clean
2525

26-
.PHONY: $(standard_targets) install-strip html man installcheck-parallel maintainer-check
26+
.PHONY: $(standard_targets) install-strip html man installcheck-parallel
2727

2828
# make `all' the default target
2929
all:

‎src/backend/access/common/bufmask.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "access/bufmask.h"
2121

2222
/*
23-
* mask_page_lsn
23+
* mask_page_lsn_and_checksum
2424
*
2525
* In consistency checks, the LSN of the two pages compared will likely be
2626
* different because of concurrent operations when the WAL is generated and

‎src/backend/access/gin/gindatapage.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1371,7 +1371,7 @@ disassembleLeaf(Page page)
13711371
if (GinPageIsCompressed(page))
13721372
{
13731373
/*
1374-
* Create a leafSegment entry for each segment.
1374+
* Create a leafSegmentInfo entry for each segment.
13751375
*/
13761376
seg = GinDataLeafPageGetPostingList(page);
13771377
segbegin = (Pointer) seg;

‎src/backend/access/heap/rewriteheap.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ static void logical_end_heap_rewrite(RewriteState state);
237237
* new_heap new, locked heap relation to insert tuples to
238238
* oldest_xmin xid used by the caller to determine which tuples are dead
239239
* freeze_xid xid before which tuples will be frozen
240-
* min_multi multixact before which multis will be removed
240+
* cutoff_multi multixact before which multis will be removed
241241
* use_wal should the inserts to the new heap be WAL-logged?
242242
*
243243
* Returns an opaque RewriteState, allocated in current memory context,
@@ -787,7 +787,7 @@ raw_heap_insert(RewriteState state, HeapTuple tup)
787787
* Instead we simply write the mapping files out to disk, *before* the
788788
* XLogInsert() is performed. That guarantees that either the XLogInsert() is
789789
* inserted after the checkpoint's redo pointer or that the checkpoint (via
790-
* LogicalRewriteHeapCheckpoint()) has flushed the (partial) mapping file to
790+
* CheckPointLogicalRewriteHeap()) has flushed the (partial) mapping file to
791791
* disk. That leaves the tail end that has not yet been flushed open to
792792
* corruption, which is solved by including the current offset in the
793793
* xl_heap_rewrite_mapping records and truncating the mapping file to it

‎src/backend/access/spgist/spgvacuum.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,7 @@ spgvacuumscan(spgBulkDeleteState *bds)
842842
}
843843
}
844844

845-
/* Propagate local lastUsedPage cache to metablock */
845+
/* Propagate local lastUsedPages cache to metablock */
846846
SpGistUpdateMetaPage(index);
847847

848848
/*

‎src/backend/access/transam/xact.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1988,7 +1988,7 @@ StartTransaction(void)
19881988

19891989
/*
19901990
* Advertise it in the proc array. We assume assignment of
1991-
* LocalTransactionID is atomic, and the backendId should be set already.
1991+
* localTransactionId is atomic, and the backendId should be set already.
19921992
*/
19931993
Assert(MyProc->backendId == vxid.backendId);
19941994
MyProc->lxid = vxid.localTransactionId;

‎src/backend/access/transam/xlog.c

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1796,11 +1796,11 @@ WaitXLogInsertionsToFinish(XLogRecPtr upto)
17961796
do
17971797
{
17981798
/*
1799-
* See if this insertion is in progress. LWLockWait will wait for
1800-
* the lock to be released, or for the 'value' to be set by a
1801-
* LWLockUpdateVar call. When a lock is initially acquired, its
1802-
* value is 0 (InvalidXLogRecPtr), which means that we don't know
1803-
* where it's inserting yet. We will have to wait for it. If
1799+
* See if this insertion is in progress. LWLockWaitForVar will
1800+
* wait for the lock to be released, or for the 'value' to be set
1801+
* by a LWLockUpdateVar call. When a lock is initially acquired,
1802+
* its value is 0 (InvalidXLogRecPtr), which means that we don't
1803+
* know where it's inserting yet. We will have to wait for it. If
18041804
* it's a small insertion, the record will most likely fit on the
18051805
* same page and the inserter will release the lock without ever
18061806
* calling LWLockUpdateVar. But if it has to sleep, it will
@@ -6024,7 +6024,10 @@ recoveryApplyDelay(XLogReaderState *record)
60246024
TimestampDifference(GetCurrentTimestamp(), recoveryDelayUntilTime,
60256025
&secs, &microsecs);
60266026

6027-
/* NB: We're ignoring waits below min_apply_delay's resolution. */
6027+
/*
6028+
* NB: We're ignoring waits below recovery_min_apply_delay's
6029+
* resolution.
6030+
*/
60286031
if (secs <= 0 && microsecs / 1000 <= 0)
60296032
break;
60306033

‎src/backend/catalog/pg_aggregate.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,7 @@ AggregateCreate(const char *aggName,
733733
* Create dependencies for the aggregate (above and beyond those already
734734
* made by ProcedureCreate). Note: we don't need an explicit dependency
735735
* on aggTransType since we depend on it indirectly through transfn.
736-
* Likewise for aggmTransType using the mtransfunc, if it exists.
736+
* Likewise for aggmTransType using the mtransfn, if it exists.
737737
*
738738
* If we're replacing an existing definition, ProcedureCreate deleted all
739739
* our existing dependencies, so we have to do the same things here either

‎src/backend/commands/dbcommands.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1854,7 +1854,7 @@ get_db_info(const char *name, LOCKMODE lockmode,
18541854
/* limit of frozen XIDs */
18551855
if (dbFrozenXidP)
18561856
*dbFrozenXidP = dbform->datfrozenxid;
1857-
/* minimum MultixactId */
1857+
/* minimum MultiXactId */
18581858
if (dbMinMultiP)
18591859
*dbMinMultiP = dbform->datminmxid;
18601860
/* default tablespace for this database */

‎src/backend/commands/operatorcmds.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@
2727
* "create operator":
2828
* operators
2929
*
30-
* Most of the parse-tree manipulation routines are defined in
31-
* commands/manip.c.
32-
*
3330
*-------------------------------------------------------------------------
3431
*/
3532
#include "postgres.h"

‎src/backend/libpq/auth.c

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1796,14 +1796,9 @@ interpret_ident_response(const char *ident_response,
17961796

17971797

17981798
/*
1799-
* Talk to the ident server on host "remote_ip_addr" and find out who
1800-
* owns the tcp connection from his port "remote_port" to port
1801-
* "local_port_addr" on host "local_ip_addr". Return the user name the
1802-
* ident server gives as "*ident_user".
1803-
*
1804-
* IP addresses and port numbers are in network byte order.
1805-
*
1806-
* But iff we're unable to get the information from ident, return false.
1799+
* Talk to the ident server on "remote_addr" and find out who
1800+
* owns the tcp connection to "local_addr"
1801+
* It the username successfully retrieved, check the usermap.
18071802
*
18081803
* XXX: Using WaitLatchOrSocket() and doing a CHECK_FOR_INTERRUPTS() if the
18091804
* latch was set would improve the responsiveness to timeouts/cancellations.

‎src/backend/postmaster/bgwriter.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -291,10 +291,10 @@ BackgroundWriterMain(void)
291291
* significantly bigger than BgWriterDelay, so we don't complicate the
292292
* overall timeout handling but just assume we're going to get called
293293
* often enough even if hibernation mode is active. It's not that
294-
* important that log_snap_interval_ms is met strictly. To make sure
295-
* we're not waking the disk up unnecessarily on an idle system we
296-
* check whether there has been any WAL inserted since the last time
297-
* we've logged a running xacts.
294+
* important that LOG_SNAPSHOT_INTERVAL_MS is met strictly. To make
295+
* sure we're not waking the disk up unnecessarily on an idle system
296+
* we check whether there has been any WAL inserted since the last
297+
* time we've logged a running xacts.
298298
*
299299
* We do this logging in the bgwriter as it is the only process that
300300
* is run regularly and returns to its mainloop all the time. E.g.

‎src/backend/replication/walsender.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2259,7 +2259,7 @@ WalSndLoop(WalSndSendDataCallback send_data)
22592259
WL_SOCKET_READABLE;
22602260

22612261
/*
2262-
* Use fresh timestamp, not last_processed, to reduce the chance
2262+
* Use fresh timestamp, not last_processing, to reduce the chance
22632263
* of reaching wal_sender_timeout before sending a keepalive.
22642264
*/
22652265
sleeptime = WalSndComputeSleeptime(GetCurrentTimestamp());
@@ -2666,7 +2666,7 @@ XLogSendPhysical(void)
26662666
* very close to together here so that we'll get a later position if it is
26672667
* still moving.
26682668
*
2669-
* Because LagTrackerWriter ignores samples when the LSN hasn't advanced,
2669+
* Because LagTrackerWrite ignores samples when the LSN hasn't advanced,
26702670
* this gives us a cheap approximation for the WAL flush time for this
26712671
* LSN.
26722672
*

‎src/backend/storage/ipc/procarray.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3169,7 +3169,7 @@ DisplayXidCache(void)
31693169
*
31703170
* When we throw away subXIDs from KnownAssignedXids, we need to keep track of
31713171
* that, similarly to tracking overflow of a PGPROC's subxids array. We do
3172-
* that by remembering the lastOverflowedXID, ie the last thrown-away subXID.
3172+
* that by remembering the lastOverflowedXid, ie the last thrown-away subXID.
31733173
* As long as that is within the range of interesting XIDs, we have to assume
31743174
* that subXIDs are missing from snapshots. (Note that subXID overflow occurs
31753175
* on primary when 65th subXID arrives, whereas on standby it occurs when 64th

‎src/backend/storage/ipc/standby.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ InitRecoveryTransactionEnvironment(void)
9999
* Lock a virtual transaction id for Startup process.
100100
*
101101
* We need to do GetNextLocalTransactionId() because
102-
* SharedInvalBackendInit() leaves localTransactionid invalid and the lock
102+
* SharedInvalBackendInit() leaves localTransactionId invalid and the lock
103103
* manager doesn't like that at all.
104104
*
105105
* Note that we don't need to run XactLockTableInsert() because nobody

‎src/backend/storage/lmgr/lwlock.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ LOG_LWDEBUG(const char *where, LWLock *lock, const char *msg)
232232

233233
static void init_lwlock_stats(void);
234234
static void print_lwlock_stats(int code, Datum arg);
235-
static lwlock_stats * get_lwlock_stats_entry(LWLock *lockid);
235+
static lwlock_stats * get_lwlock_stats_entry(LWLock *lock);
236236

237237
static void
238238
init_lwlock_stats(void)

‎src/backend/storage/smgr/md.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -731,7 +731,7 @@ mdwrite(SMgrRelation reln, ForkNumber forknum, BlockNumber blocknum,
731731
* mdnblocks() -- Get the number of blocks stored in a relation.
732732
*
733733
* Important side effect: all active segments of the relation are opened
734-
* and added to the mdfd_seg_fds array. If this routine has not been
734+
* and added to the md_seg_fds array. If this routine has not been
735735
* called, then only segments up to the last one actually touched
736736
* are present in the array.
737737
*/

‎src/backend/tcop/pquery.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1023,8 +1023,8 @@ FillPortalStore(Portal portal, bool isTopLevel)
10231023

10241024
/*
10251025
* Run the portal to completion just as for the default
1026-
* MULTI_QUERY case, but send the primary query's output to the
1027-
* tuplestore. Auxiliary query outputs are discarded. Set the
1026+
* PORTAL_MULTI_QUERY case, but send the primary query's output to
1027+
* the tuplestore. Auxiliary query outputs are discarded. Set the
10281028
* portal's holdSnapshot to the snapshot used (or a copy of it).
10291029
*/
10301030
PortalRunMulti(portal, isTopLevel, true,

‎src/backend/utils/adt/arrayfuncs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ static void array_insert_slice(ArrayType *destArray, ArrayType *origArray,
139139
int *st, int *endp,
140140
int typlen, bool typbyval, char typalign);
141141
static int array_cmp(FunctionCallInfo fcinfo);
142-
static ArrayType *create_array_envelope(int ndims, int *dimv, int *lbv, int nbytes,
142+
static ArrayType *create_array_envelope(int ndims, int *dimv, int *lbsv, int nbytes,
143143
Oid elmtype, int dataoffset);
144144
static ArrayType *array_fill_internal(ArrayType *dims, ArrayType *lbs,
145145
Datum value, bool isnull, Oid elmtype,

‎src/backend/utils/adt/like_match.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@
2727
/*
2828
* Originally written by Rich $alz, mirror!rs, Wed Nov 26 19:03:17 EST 1986.
2929
* Rich $alz is now <rsalz@bbn.com>.
30-
* Special thanks to Lars Mathiesen <thorinn@diku.dk> for the LABORT code.
30+
* Special thanks to Lars Mathiesen <thorinn@diku.dk> for the
31+
* LIKE_ABORT code.
3132
*
3233
* This code was shamelessly stolen from the "pql" code by myself and
3334
* slightly modified :)

‎src/backend/utils/mmgr/aset.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -915,7 +915,7 @@ AllocSetAlloc(MemoryContext context, Size size)
915915

916916
/*
917917
* We could be asking for pretty big blocks here, so cope if malloc
918-
* fails. But give up if there's less than a meg or so available...
918+
* fails. But give up if there's less than 1 MB or so available...
919919
*/
920920
while (block == NULL && blksize > 1024 * 1024)
921921
{

‎src/bin/initdb/initdb.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2024,7 +2024,7 @@ make_template0(FILE *cmdfd)
20242024
"CREATE DATABASE template0 IS_TEMPLATE = true ALLOW_CONNECTIONS = false;\n\n",
20252025

20262026
/*
2027-
* We use the OID of template0 to determine lastsysoid
2027+
* We use the OID of template0 to determine datlastsysoid
20282028
*/
20292029
"UPDATE pg_database SET datlastsysoid = "
20302030
" (SELECT oid FROM pg_database "

‎src/bin/pg_controldata/pg_controldata.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* reads the data from $PGDATA/global/pg_control
55
*
66
* copyright (c) Oliver Elphick <olly@lfix.co.uk>, 2001;
7-
* licence: BSD
7+
* license: BSD
88
*
99
* src/bin/pg_controldata/pg_controldata.c
1010
*/

‎src/bin/pg_ctl/pg_ctl.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1725,7 +1725,7 @@ pgwin32_doRunAsService(void)
17251725
/*
17261726
* Mingw headers are incomplete, and so are the libraries. So we have to load
17271727
* a whole lot of API functions dynamically. Since we have to do this anyway,
1728-
* also load the couple of functions that *do* exist in minwg headers but not
1728+
* also load the couple of functions that *do* exist in mingw headers but not
17291729
* on NT4. That way, we don't break on NT4.
17301730
*/
17311731
typedef BOOL (WINAPI * __CreateRestrictedToken) (HANDLE, DWORD, DWORD, PSID_AND_ATTRIBUTES, DWORD, PLUID_AND_ATTRIBUTES, DWORD, PSID_AND_ATTRIBUTES, PHANDLE);

‎src/bin/pg_upgrade/pg_upgrade.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,8 @@
1919
#define USER_NAME_SIZE 128
2020

2121
#define MAX_STRING 1024
22-
#define LINE_ALLOC 4096
2322
#define QUERY_ALLOC 8192
2423

25-
#define MIGRATOR_API_VERSION 1
26-
2724
#define MESSAGE_WIDTH 60
2825

2926
#define GET_MAJOR_VERSION(v) ((v) / 100)

‎src/bin/pgevent/README

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ src/bin/pgevent/README
33
pgevent
44
=======
55

6-
MSG000001.bin is a binary file, result of Microsoft MC compiler. MC compiler
6+
MSG00001.bin is a binary file, result of Microsoft MC compiler. MC compiler
77
can be downloaded for free with MS Core SDK but it is not included with MSYS
88
tools and I didn't find an alternative way to compile MC file.
99

‎src/common/unicode_norm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ recompose_code(uint32 start, uint32 code, uint32 *result)
178178
((start - SBASE) % TCOUNT) == 0 &&
179179
code >= TBASE && code < (TBASE + TCOUNT))
180180
{
181-
/* make syllable of from LVT */
181+
/* make syllable of form LVT */
182182
uint32 tindex = code - TBASE;
183183

184184
*result = start + tindex;

‎src/include/access/gist_private.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,7 @@ extern bool gistplacetopage(Relation rel, Size freespace, GISTSTATE *giststate,
417417
OffsetNumber oldoffnum, BlockNumber *newblkno,
418418
Buffer leftchildbuf,
419419
List **splitinfo,
420-
bool markleftchild,
420+
bool markfollowright,
421421
Relation heapRel,
422422
bool is_build);
423423

‎src/include/commands/dbcommands.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ extern Oid AlterDatabase(ParseState *pstate, AlterDatabaseStmt *stmt, bool isTop
2626
extern Oid AlterDatabaseSet(AlterDatabaseSetStmt *stmt);
2727
extern ObjectAddress AlterDatabaseOwner(const char *dbname, Oid newOwnerId);
2828

29-
extern Oid get_database_oid(const char *dbname, bool missingok);
29+
extern Oid get_database_oid(const char *dbname, bool missing_ok);
3030
extern char *get_database_name(Oid dbid);
3131

3232
extern void check_encoding_locale_matches(int encoding, const char *collate, const char *ctype);

‎src/include/replication/logicalproto.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@
1919
/*
2020
* Protocol capabilities
2121
*
22-
* LOGICAL_PROTO_VERSION_NUM is our native protocol and the greatest version
23-
* we can support. PGLOGICAL_PROTO_MIN_VERSION_NUM is the oldest version we
22+
* LOGICALREP_PROTO_VERSION_NUM is our native protocol and the greatest version
23+
* we can support. LOGICALREP_PROTO_MIN_VERSION_NUM is the oldest version we
2424
* have backwards compatibility for. The client requests protocol version at
2525
* connect time.
2626
*/
@@ -106,4 +106,4 @@ extern LogicalRepRelation *logicalrep_read_rel(StringInfo in);
106106
extern void logicalrep_write_typ(StringInfo out, Oid typoid);
107107
extern void logicalrep_read_typ(StringInfo out, LogicalRepTyp *ltyp);
108108

109-
#endif /* LOGICALREP_PROTO_H */
109+
#endif /* LOGICAL_PROTO_H */

‎src/include/statistics/statistics.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
#define STATS_NDISTINCT_MAGIC 0xA352BFA4 /* struct identifier */
2323
#define STATS_NDISTINCT_TYPE_BASIC 1 /* struct version */
2424

25-
/* MVDistinctItem represents a single combination of columns */
25+
/* MVNDistinctItem represents a single combination of columns */
2626
typedef struct MVNDistinctItem
2727
{
2828
double ndistinct; /* ndistinct value for this combination */

‎src/include/storage/bufpage.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,7 @@ typedef PageHeaderData *PageHeader;
306306
* This is intended to catch use of the pointer before page initialization.
307307
* It is implemented as a function due to the limitations of the MSVC
308308
* compiler, which choked on doing all these tests within another macro. We
309-
* return true so that MacroAssert() can be used while still getting the
309+
* return true so that AssertMacro() can be used while still getting the
310310
* specifics from the macro failure within this function.
311311
*/
312312
static inline bool

0 commit comments

Comments
 (0)