Error message capitalisation

petere · petere · commit ed1e0a65127a · 2024-01-18T09:35:12.000+01:00
per style guidelines Author: Peter Smith <peter.b.smith@fujitsu.com> Discussion: https://www.postgresql.org/message-id/flat/CAHut%2BPtzstExQ4%3DvFH%2BWzZ4g4xEx2JA%3DqxussxOdxVEwJce6bw%40mail.gmail.com
diff --git a/contrib/pg_surgery/heap_surgery.c b/contrib/pg_surgery/heap_surgery.c
@@ -95,7 +95,7 @@ heap_force_common(FunctionCallInfo fcinfo, HeapTupleForceOption heap_force_opt)
 		ereport(ERROR,
 				(errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
 				 errmsg("recovery is in progress"),
-				 errhint("heap surgery functions cannot be executed during recovery.")));
+				 errhint("Heap surgery functions cannot be executed during recovery.")));
 
 	/* Check inputs. */
 	sanity_check_tid_array(ta, &ntids);
diff --git a/src/backend/commands/event_trigger.c b/src/backend/commands/event_trigger.c
@@ -174,7 +174,7 @@ CreateEventTrigger(CreateEventTrigStmt *stmt)
 	else if (strcmp(stmt->eventname, "login") == 0 && tags != NULL)
 		ereport(ERROR,
 				(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
-				 errmsg("Tag filtering is not supported for login event trigger")));
+				 errmsg("tag filtering is not supported for login event trigger")));
 
 	/*
 	 * Give user a nice error message if an event trigger of the same name
diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
@@ -3961,7 +3961,7 @@ check_debug_io_direct(char **newval, void **extra, GucSource source)
 
 	if (!SplitGUCList(rawstring, ',', &elemlist))
 	{
-		GUC_check_errdetail("invalid list syntax in parameter %s",
+		GUC_check_errdetail("Invalid list syntax in parameter %s",
 							"debug_io_direct");
 		pfree(rawstring);
 		list_free(elemlist);
@@ -3981,7 +3981,7 @@ check_debug_io_direct(char **newval, void **extra, GucSource source)
 			flags |= IO_DIRECT_WAL_INIT;
 		else
 		{
-			GUC_check_errdetail("invalid option \"%s\"", item);
+			GUC_check_errdetail("Invalid option \"%s\"", item);
 			result = false;
 			break;
 		}
diff --git a/src/backend/tcop/postgres.c b/src/backend/tcop/postgres.c
@@ -2479,7 +2479,7 @@ errdetail_params(ParamListInfo params)
 
 		str = BuildParamLogString(params, NULL, log_parameter_max_length);
 		if (str && str[0] != '\0')
-			errdetail("parameters: %s", str);
+			errdetail("Parameters: %s", str);
 	}
 
 	return 0;
@@ -2494,7 +2494,7 @@ static int
 errdetail_abort(void)
 {
 	if (MyProc->recoveryConflictPending)
-		errdetail("abort reason: recovery conflict");
+		errdetail("Abort reason: recovery conflict");
 
 	return 0;
 }
diff --git a/src/backend/utils/error/elog.c b/src/backend/utils/error/elog.c
@@ -2140,7 +2140,7 @@ check_backtrace_functions(char **newval, void **extra, GucSource source)
 					  ", \n\t");
 	if (validlen != newvallen)
 	{
-		GUC_check_errdetail("invalid character");
+		GUC_check_errdetail("Invalid character");
 		return false;
 	}
 
diff --git a/src/bin/pgbench/t/001_pgbench_with_server.pl b/src/bin/pgbench/t/001_pgbench_with_server.pl
@@ -290,7 +290,7 @@ sub check_data_state
 my $log = PostgreSQL::Test::Utils::slurp_file($node->logfile);
 unlike(
 	$log,
-	qr[DETAIL:  parameters: \$1 = '\{ invalid ',],
+	qr[DETAIL:  Parameters: \$1 = '\{ invalid ',],
 	"no parameters logged");
 $log = undef;
 
@@ -331,7 +331,7 @@ sub check_data_state
 $log = PostgreSQL::Test::Utils::slurp_file($node->logfile);
 like(
 	$log,
-	qr[DETAIL:  parameters: \$1 = '\{ invalid ', \$2 = '''Valame Dios!'' dijo Sancho; ''no le dije yo a vuestra merced que mirase bien lo que hacia\?'''],
+	qr[DETAIL:  Parameters: \$1 = '\{ invalid ', \$2 = '''Valame Dios!'' dijo Sancho; ''no le dije yo a vuestra merced que mirase bien lo que hacia\?'''],
 	"parameter report does not truncate");
 $log = undef;
 
@@ -376,7 +376,7 @@ sub check_data_state
 $log = PostgreSQL::Test::Utils::slurp_file($node->logfile);
 like(
 	$log,
-	qr[DETAIL:  parameters: \$1 = '\{ inval\.\.\.', \$2 = '''Valame\.\.\.'],
+	qr[DETAIL:  Parameters: \$1 = '\{ inval\.\.\.', \$2 = '''Valame\.\.\.'],
 	"parameter report truncates");
 $log = undef;
 

Original file line number	Diff line number	Diff line change
`@@ -3961,7 +3961,7 @@ check_debug_io_direct(char newval, void extra, GucSource source)`
`3961`	`3961`
`3962`	`3962`	`if (!SplitGUCList(rawstring, ',', &elemlist))`
`3963`	`3963`	`{`
`3964`		`- GUC_check_errdetail("invalid list syntax in parameter %s",`
	`3964`	`+ GUC_check_errdetail("Invalid list syntax in parameter %s",`
`3965`	`3965`	`"debug_io_direct");`
`3966`	`3966`	`pfree(rawstring);`
`3967`	`3967`	`list_free(elemlist);`
`@@ -3981,7 +3981,7 @@ check_debug_io_direct(char newval, void extra, GucSource source)`
`3981`	`3981`	`flags \|= IO_DIRECT_WAL_INIT;`
`3982`	`3982`	`else`
`3983`	`3983`	`{`
`3984`		`- GUC_check_errdetail("invalid option \"%s\"", item);`
	`3984`	`+ GUC_check_errdetail("Invalid option \"%s\"", item);`
`3985`	`3985`	`result = false;`
`3986`	`3986`	`break;`
`3987`	`3987`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2479,7 +2479,7 @@ errdetail_params(ParamListInfo params)`
`2479`	`2479`
`2480`	`2480`	`str = BuildParamLogString(params, NULL, log_parameter_max_length);`
`2481`	`2481`	`if (str && str[0] != '\0')`
`2482`		`- errdetail("parameters: %s", str);`
	`2482`	`+ errdetail("Parameters: %s", str);`
`2483`	`2483`	`}`
`2484`	`2484`
`2485`	`2485`	`return 0;`
`@@ -2494,7 +2494,7 @@ static int`
`2494`	`2494`	`errdetail_abort(void)`
`2495`	`2495`	`{`
`2496`	`2496`	`if (MyProc->recoveryConflictPending)`
`2497`		`- errdetail("abort reason: recovery conflict");`
	`2497`	`+ errdetail("Abort reason: recovery conflict");`
`2498`	`2498`
`2499`	`2499`	`return 0;`
`2500`	`2500`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2140,7 +2140,7 @@ check_backtrace_functions(char newval, void extra, GucSource source)`
`2140`	`2140`	`", \n\t");`
`2141`	`2141`	`if (validlen != newvallen)`
`2142`	`2142`	`{`
`2143`		`- GUC_check_errdetail("invalid character");`
	`2143`	`+ GUC_check_errdetail("Invalid character");`
`2144`	`2144`	`return false;`
`2145`	`2145`	`}`
`2146`	`2146`