Fix compiler warning in unistr function

david-rowley · david-rowley · commit efd9d92bb39c · 2021-03-30T20:28:09.000+13:00
Some compilers are not aware that elog/ereport ERROR does not return.
diff --git a/src/backend/utils/adt/varlena.c b/src/backend/utils/adt/varlena.c
@@ -6589,4 +6589,5 @@ unistr(PG_FUNCTION_ARGS)
 	ereport(ERROR,
 			(errcode(ERRCODE_SYNTAX_ERROR),
 			 errmsg("invalid Unicode surrogate pair")));
+	PG_RETURN_NULL();			/* keep compiler quiet */
 }

Original file line number	Diff line number	Diff line change
`@@ -6589,4 +6589,5 @@ unistr(PG_FUNCTION_ARGS)`
`6589`	`6589`	`ereport(ERROR,`
`6590`	`6590`	`(errcode(ERRCODE_SYNTAX_ERROR),`
`6591`	`6591`	`errmsg("invalid Unicode surrogate pair")));`
	`6592`	`+ PG_RETURN_NULL(); /* keep compiler quiet */`
`6592`	`6593`	`}`