Free memory properly in pg_restore.c

adunstan · adunstan · commit f09088a01d33 · 2025-04-12T14:54:48.000-04:00
Thinko in commit 39729ec. Mea maxima culpa. Per Mahendra Singh Thalor <mahi6run@gmail.com>
diff --git a/src/bin/pg_dump/pg_restore.c b/src/bin/pg_dump/pg_restore.c
@@ -906,7 +906,7 @@ read_one_statement(StringInfo inBuf, FILE *pfile)
 			appendStringInfoChar(inBuf, (char) '\n');
 	}
 
-	destroyStringInfo(&q);
+	pg_free(q.data);
 
 	/* No input before EOF signal means time to quit. */
 	if (c == EOF && inBuf->len == 0)

Original file line number	Diff line number	Diff line change
`@@ -906,7 +906,7 @@ read_one_statement(StringInfo inBuf, FILE *pfile)`
`906`	`906`	`appendStringInfoChar(inBuf, (char) '\n');`
`907`	`907`	`}`
`908`	`908`
`909`		`- destroyStringInfo(&q);`
	`909`	`+ pg_free(q.data);`
`910`	`910`
`911`	`911`	`/* No input before EOF signal means time to quit. */`
`912`	`912`	`if (c == EOF && inBuf->len == 0)`