Skip to content

Commit f09346a

Browse files
tglsfdctglsfdc
committed
Refactor planner's header files.
Create a new header optimizer/optimizer.h, which exposes just the planner functions that can be used "at arm's length", without need to access Paths or the other planner-internal data structures defined in nodes/relation.h. This is intended to provide the whole planner API seen by most of the rest of the system; although FDWs still need to use additional stuff, and more thought is also needed about just what selfuncs.c should rely on. The main point of doing this now is to limit the amount of new #include baggage that will be needed by "planner support functions", which I expect to introduce later, and which will be in relevant datatype modules rather than anywhere near the planner. This commit just moves relevant declarations into optimizer.h from other header files (a couple of which go away because everything got moved), and adjusts #include lists to match. There's further cleanup that could be done if we want to decide that some stuff being exposed by optimizer.h doesn't belong in the planner at all, but I'll leave that for another day. Discussion: https://postgr.es/m/11460.1548706639@sss.pgh.pa.us
1 parent a1b8c41 commit f09346a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

91 files changed

+278
-303
lines changed

‎contrib/bloom/blcost.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
#include "postgres.h"
1414

1515
#include "fmgr.h"
16-
#include "optimizer/cost.h"
1716
#include "utils/selfuncs.h"
1817

1918
#include "bloom.h"

‎contrib/file_fdw/file_fdw.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,10 @@
2929
#include "foreign/foreign.h"
3030
#include "miscadmin.h"
3131
#include "nodes/makefuncs.h"
32-
#include "optimizer/cost.h"
32+
#include "optimizer/optimizer.h"
3333
#include "optimizer/pathnode.h"
3434
#include "optimizer/planmain.h"
3535
#include "optimizer/restrictinfo.h"
36-
#include "optimizer/var.h"
3736
#include "utils/memutils.h"
3837
#include "utils/rel.h"
3938
#include "utils/sampling.h"

‎contrib/postgres_fdw/deparse.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,9 @@
4848
#include "nodes/makefuncs.h"
4949
#include "nodes/nodeFuncs.h"
5050
#include "nodes/plannodes.h"
51-
#include "optimizer/clauses.h"
51+
#include "optimizer/optimizer.h"
5252
#include "optimizer/prep.h"
5353
#include "optimizer/tlist.h"
54-
#include "optimizer/var.h"
5554
#include "parser/parsetree.h"
5655
#include "utils/builtins.h"
5756
#include "utils/lsyscache.h"

‎contrib/postgres_fdw/postgres_fdw.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,11 @@
2828
#include "nodes/nodeFuncs.h"
2929
#include "optimizer/cost.h"
3030
#include "optimizer/clauses.h"
31+
#include "optimizer/optimizer.h"
3132
#include "optimizer/pathnode.h"
3233
#include "optimizer/paths.h"
3334
#include "optimizer/planmain.h"
3435
#include "optimizer/restrictinfo.h"
35-
#include "optimizer/var.h"
3636
#include "optimizer/tlist.h"
3737
#include "parser/parsetree.h"
3838
#include "utils/builtins.h"

‎contrib/tsm_system_rows/tsm_system_rows.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@
3333
#include "access/tsmapi.h"
3434
#include "catalog/pg_type.h"
3535
#include "miscadmin.h"
36-
#include "optimizer/clauses.h"
37-
#include "optimizer/cost.h"
36+
#include "optimizer/optimizer.h"
3837
#include "utils/sampling.h"
3938

4039
PG_MODULE_MAGIC;

‎contrib/tsm_system_time/tsm_system_time.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@
3131
#include "access/tsmapi.h"
3232
#include "catalog/pg_type.h"
3333
#include "miscadmin.h"
34-
#include "optimizer/clauses.h"
35-
#include "optimizer/cost.h"
34+
#include "optimizer/optimizer.h"
3635
#include "utils/sampling.h"
3736
#include "utils/spccache.h"
3837

‎src/backend/access/gist/gistbuild.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
#include "access/xloginsert.h"
2323
#include "catalog/index.h"
2424
#include "miscadmin.h"
25-
#include "optimizer/cost.h"
25+
#include "optimizer/optimizer.h"
2626
#include "storage/bufmgr.h"
2727
#include "storage/smgr.h"
2828
#include "utils/memutils.h"

‎src/backend/access/spgist/spgutils.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#include "access/transam.h"
2323
#include "access/xact.h"
2424
#include "catalog/pg_amop.h"
25-
#include "optimizer/paths.h"
2625
#include "storage/bufmgr.h"
2726
#include "storage/indexfsm.h"
2827
#include "storage/lmgr.h"
@@ -32,9 +31,6 @@
3231
#include "utils/lsyscache.h"
3332
#include "utils/syscache.h"
3433

35-
extern Expr *spgcanorderbyop(IndexOptInfo *index,
36-
PathKey *pathkey, int pathkeyno,
37-
Expr *orderby_clause, int *indexcol_p);
3834

3935
/*
4036
* SP-GiST handler function: return IndexAmRoutine with access method parameters

‎src/backend/access/tablesample/bernoulli.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
#include "access/hash.h"
3030
#include "access/tsmapi.h"
3131
#include "catalog/pg_type.h"
32-
#include "optimizer/clauses.h"
33-
#include "optimizer/cost.h"
32+
#include "optimizer/optimizer.h"
3433
#include "utils/builtins.h"
3534

3635

‎src/backend/access/tablesample/system.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@
3131
#include "access/relscan.h"
3232
#include "access/tsmapi.h"
3333
#include "catalog/pg_type.h"
34-
#include "optimizer/clauses.h"
35-
#include "optimizer/cost.h"
34+
#include "optimizer/optimizer.h"
3635
#include "utils/builtins.h"
3736

3837

0 commit comments

Comments
 (0)