pg_upgrade: improve instructions for fixing incompatible isn use

bmomjian · bmomjian · commit f0b57aec1d41 · 2019-11-27T20:24:57.000-05:00
This clarifies instructions on how to dump/reload databases that use incompatible isn versions. Reported-by: Alvaro Herrera Discussion: https://postgr.es/m/20191114190652.GA23586@alvherre.pgsql Reviewed-by: Daniel Gustafsson <daniel@yesql.se> Backpatch-through: 13
diff --git a/src/bin/pg_upgrade/check.c b/src/bin/pg_upgrade/check.c
@@ -887,9 +887,9 @@ check_for_isn_and_int8_passing_mismatch(ClusterInfo *cluster)
 		pg_fatal("Your installation contains \"contrib/isn\" functions which rely on the\n"
 				 "bigint data type.  Your old and new clusters pass bigint values\n"
 				 "differently so this cluster cannot currently be upgraded.  You can\n"
-				 "manually upgrade databases that use \"contrib/isn\" facilities and remove\n"
-				 "\"contrib/isn\" from the old cluster and restart the upgrade.  A list of\n"
-				 "the problem functions is in the file:\n"
+				 "manually dump databases in the old cluster that use \"contrib/isn\"\n"
+				 "facilities, drop them, perform the upgrade, and then restore them.  A\n"
+				 "list of the problem functions is in the file:\n"
 				 "    %s\n\n", output_path);
 	}
 	else
