Remove unnecessary lo_lseek call in lo_open. Apparently there was once

tglsfdc · tglsfdc · commit f0bfc02001c5 · 2006-03-02T21:56:14.000Z
a need for it back in the neolithic era, but it's certainly dead code in
any PG release we would recognize as such.  Since it forces an additional
network round trip to the backend, getting rid of it should provide some
small performance improvement for large-object-using clients.
diff --git a/src/interfaces/libpq/fe-lobj.c b/src/interfaces/libpq/fe-lobj.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-lobj.c,v 1.54 2005/10/15 02:49:48 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-lobj.c,v 1.55 2006/03/02 21:56:14 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -76,11 +76,6 @@ lo_open(PGconn *conn, Oid lobjId, int mode)
 	if (PQresultStatus(res) == PGRES_COMMAND_OK)
 	{
 		PQclear(res);
-
-		/* have to do this to reset offset in shared fd cache */
-		/* but only if fd is valid */
-		if (fd >= 0 && lo_lseek(conn, fd, 0L, SEEK_SET) < 0)
-			return -1;
 		return fd;
 	}
 	else

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/interfaces/libpq/fe-lobj.c,v 1.54 2005/10/15 02:49:48 momjian Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/interfaces/libpq/fe-lobj.c,v 1.55 2006/03/02 21:56:14 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -76,11 +76,6 @@ lo_open(PGconn *conn, Oid lobjId, int mode)`
`76`	`76`	`if (PQresultStatus(res) == PGRES_COMMAND_OK)`
`77`	`77`	`{`
`78`	`78`	`PQclear(res);`
`79`		`-`
`80`		`- /* have to do this to reset offset in shared fd cache */`
`81`		`- /* but only if fd is valid */`
`82`		`- if (fd >= 0 && lo_lseek(conn, fd, 0L, SEEK_SET) < 0)`
`83`		`- return -1;`
`84`	`79`	`return fd;`
`85`	`80`	`}`
`86`	`81`	`else`