Fix pgperlcritic complaint, per buildfarm.

jeff-davis · jeff-davis · commit f1e90859cef3 · 2022-01-08T09:27:43.000-08:00
Author: Michael Paquier Discussion: https://postgr.es/m/YdlYfS/l%2BPQA0ehs%40paquier.xyz
diff --git a/src/test/subscription/t/027_nosuperuser.pl b/src/test/subscription/t/027_nosuperuser.pl
@@ -10,7 +10,7 @@
 my ($node_publisher, $node_subscriber, $publisher_connstr, $result, $offset);
 $offset = 0;
 
-sub publish_insert($$)
+sub publish_insert
 {
   my ($tbl, $new_i) = @_;
   $node_publisher->safe_psql('postgres', qq(
@@ -19,7 +19,7 @@ ($$)
   ));
 }
 
-sub publish_update($$$)
+sub publish_update
 {
   my ($tbl, $old_i, $new_i) = @_;
   $node_publisher->safe_psql('postgres', qq(
@@ -28,7 +28,7 @@ ($$$)
   ));
 }
 
-sub publish_delete($$)
+sub publish_delete
 {
   my ($tbl, $old_i) = @_;
   $node_publisher->safe_psql('postgres', qq(
@@ -37,7 +37,7 @@ ($$)
   ));
 }
 
-sub expect_replication($$$$$)
+sub expect_replication
 {
   my ($tbl, $cnt, $min, $max, $testname) = @_;
   $node_publisher->wait_for_catchup('admin_sub');
@@ -46,7 +46,7 @@ ($$$$$)
   is ($result, "$cnt|$min|$max", $testname);
 }
 
-sub expect_failure($$$$$$)
+sub expect_failure
 {
   my ($tbl, $cnt, $min, $max, $re, $testname) = @_;
   $offset = $node_subscriber->wait_for_log($re, $offset);
@@ -55,28 +55,28 @@ ($$$$$$)
   is ($result, "$cnt|$min|$max", $testname);
 }
 
-sub revoke_superuser($)
+sub revoke_superuser
 {
   my ($role) = @_;
   $node_subscriber->safe_psql('postgres', qq(
   ALTER ROLE $role NOSUPERUSER));
 }
 
-sub grant_superuser($)
+sub grant_superuser
 {
   my ($role) = @_;
   $node_subscriber->safe_psql('postgres', qq(
   ALTER ROLE $role SUPERUSER));
 }
 
-sub revoke_bypassrls($)
+sub revoke_bypassrls
 {
   my ($role) = @_;
   $node_subscriber->safe_psql('postgres', qq(
   ALTER ROLE $role NOBYPASSRLS));
 }
 
-sub grant_bypassrls($)
+sub grant_bypassrls
 {
   my ($role) = @_;
   $node_subscriber->safe_psql('postgres', qq(

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`	`my ($node_publisher, $node_subscriber, $publisher_connstr, $result, $offset);`
`11`	`11`	`$offset = 0;`
`12`	`12`
`13`		`-sub publish_insert($$)`
	`13`	`+sub publish_insert`
`14`	`14`	`{`
`15`	`15`	`my ($tbl, $new_i) = @_;`
`16`	`16`	`$node_publisher->safe_psql('postgres', qq(`
`@@ -19,7 +19,7 @@ ($$)`
`19`	`19`	`));`
`20`	`20`	`}`
`21`	`21`
`22`		`-sub publish_update($$$)`
	`22`	`+sub publish_update`
`23`	`23`	`{`
`24`	`24`	`my ($tbl, $old_i, $new_i) = @_;`
`25`	`25`	`$node_publisher->safe_psql('postgres', qq(`
`@@ -28,7 +28,7 @@ ($$$)`
`28`	`28`	`));`
`29`	`29`	`}`
`30`	`30`
`31`		`-sub publish_delete($$)`
	`31`	`+sub publish_delete`
`32`	`32`	`{`
`33`	`33`	`my ($tbl, $old_i) = @_;`
`34`	`34`	`$node_publisher->safe_psql('postgres', qq(`
`@@ -37,7 +37,7 @@ ($$)`
`37`	`37`	`));`
`38`	`38`	`}`
`39`	`39`
`40`		`-sub expect_replication($$$$$)`
	`40`	`+sub expect_replication`
`41`	`41`	`{`
`42`	`42`	`my ($tbl, $cnt, $min, $max, $testname) = @_;`
`43`	`43`	`$node_publisher->wait_for_catchup('admin_sub');`
`@@ -46,7 +46,7 @@ ($$$$$)`
`46`	`46`	`is ($result, "$cnt\|$min\|$max", $testname);`
`47`	`47`	`}`
`48`	`48`
`49`		`-sub expect_failure($$$$$$)`
	`49`	`+sub expect_failure`
`50`	`50`	`{`
`51`	`51`	`my ($tbl, $cnt, $min, $max, $re, $testname) = @_;`
`52`	`52`	`$offset = $node_subscriber->wait_for_log($re, $offset);`
`@@ -55,28 +55,28 @@ ($$$$$$)`
`55`	`55`	`is ($result, "$cnt\|$min\|$max", $testname);`
`56`	`56`	`}`
`57`	`57`
`58`		`-sub revoke_superuser($)`
	`58`	`+sub revoke_superuser`
`59`	`59`	`{`
`60`	`60`	`my ($role) = @_;`
`61`	`61`	`$node_subscriber->safe_psql('postgres', qq(`
`62`	`62`	`ALTER ROLE $role NOSUPERUSER));`
`63`	`63`	`}`
`64`	`64`
`65`		`-sub grant_superuser($)`
	`65`	`+sub grant_superuser`
`66`	`66`	`{`
`67`	`67`	`my ($role) = @_;`
`68`	`68`	`$node_subscriber->safe_psql('postgres', qq(`
`69`	`69`	`ALTER ROLE $role SUPERUSER));`
`70`	`70`	`}`
`71`	`71`
`72`		`-sub revoke_bypassrls($)`
	`72`	`+sub revoke_bypassrls`
`73`	`73`	`{`
`74`	`74`	`my ($role) = @_;`
`75`	`75`	`$node_subscriber->safe_psql('postgres', qq(`
`76`	`76`	`ALTER ROLE $role NOBYPASSRLS));`
`77`	`77`	`}`
`78`	`78`
`79`		`-sub grant_bypassrls($)`
	`79`	`+sub grant_bypassrls`
`80`	`80`	`{`
`81`	`81`	`my ($role) = @_;`
`82`	`82`	`$node_subscriber->safe_psql('postgres', qq(`