Use return instead of exit() in configure

tglsfdc · tglsfdc · commit f24374bce687 · 2021-12-12T14:54:32.000-05:00
Using exit() requires stdlib.h, which is not included. Use return instead. Also add return type for main(). This back-patches commit 1c0cf52 into out-of-support branches, pursuant to a newly-established project policy that we'll try to keep out-of-support branches buildable on modern platforms for at least ten major releases back, ensuring people can test pg_dump and psql compatibility against servers that far back. With the current development branch being v15, that works out to keeping 9.2 and up buildable as of today. This fix is needed to get through 'configure' when using recent macOS (and possibly other clang-based toolchains). It seems to be sufficient to get through 'check-world', although there are annoyances such as compiler warnings, which will be dealt with separately. Original patch by Peter Eisentraut Discussion: https://postgr.es/m/d0316012-ece7-7b7e-2d36-9c38cb77cb3b@enterprisedb.com
diff --git a/config/c-compiler.m4 b/config/c-compiler.m4
@@ -84,8 +84,10 @@ int does_int64_work()
     return 0;
   return 1;
 }
+
+int
 main() {
-  exit(! does_int64_work());
+  return (! does_int64_work());
 }],
 [Ac_cachevar=yes],
 [Ac_cachevar=no],
diff --git a/config/c-library.m4 b/config/c-library.m4
@@ -251,8 +251,10 @@ int does_int64_snprintf_work()
     return 0;			/* either multiply or snprintf is busted */
   return 1;
 }
+
+int
 main() {
-  exit(! does_int64_snprintf_work());
+  return (! does_int64_snprintf_work());
 }],
 [pgac_cv_snprintf_long_long_int_format=$pgac_format; break],
 [],
diff --git a/configure b/configure
@@ -25530,8 +25530,10 @@ int does_int64_work()
     return 0;
   return 1;
 }
+
+int
 main() {
-  exit(! does_int64_work());
+  return (! does_int64_work());
 }
 _ACEOF
 rm -f conftest$ac_exeext
@@ -25669,8 +25671,10 @@ int does_int64_work()
     return 0;
   return 1;
 }
+
+int
 main() {
-  exit(! does_int64_work());
+  return (! does_int64_work());
 }
 _ACEOF
 rm -f conftest$ac_exeext
@@ -25780,8 +25784,10 @@ int does_int64_snprintf_work()
     return 0;			/* either multiply or snprintf is busted */
   return 1;
 }
+
+int
 main() {
-  exit(! does_int64_snprintf_work());
+  return (! does_int64_snprintf_work());
 }
 _ACEOF
 rm -f conftest$ac_exeext

Original file line number	Diff line number	Diff line change
`@@ -25530,8 +25530,10 @@ int does_int64_work()`
`25530`	`25530`	`return 0;`
`25531`	`25531`	`return 1;`
`25532`	`25532`	`}`
	`25533`	`+`
	`25534`	`+int`
`25533`	`25535`	`main() {`
`25534`		`- exit(! does_int64_work());`
	`25536`	`+ return (! does_int64_work());`
`25535`	`25537`	`}`
`25536`	`25538`	`_ACEOF`
`25537`	`25539`	`rm -f conftest$ac_exeext`
`@@ -25669,8 +25671,10 @@ int does_int64_work()`
`25669`	`25671`	`return 0;`
`25670`	`25672`	`return 1;`
`25671`	`25673`	`}`
	`25674`	`+`
	`25675`	`+int`
`25672`	`25676`	`main() {`
`25673`		`- exit(! does_int64_work());`
	`25677`	`+ return (! does_int64_work());`
`25674`	`25678`	`}`
`25675`	`25679`	`_ACEOF`
`25676`	`25680`	`rm -f conftest$ac_exeext`
`@@ -25780,8 +25784,10 @@ int does_int64_snprintf_work()`
`25780`	`25784`	`return 0; /* either multiply or snprintf is busted */`
`25781`	`25785`	`return 1;`
`25782`	`25786`	`}`
	`25787`	`+`
	`25788`	`+int`
`25783`	`25789`	`main() {`
`25784`		`- exit(! does_int64_snprintf_work());`
	`25790`	`+ return (! does_int64_snprintf_work());`
`25785`	`25791`	`}`
`25786`	`25792`	`_ACEOF`
`25787`	`25793`	`rm -f conftest$ac_exeext`