Suppress bogus statistics when pgbench failed to complete any transactions.

tglsfdc · tglsfdc · commit f2a3cdb6dbe4 · 2014-12-16T14:53:58.000-05:00
Code added in 9.4 would attempt to divide by zero in such cases.
Noted while testing fix for missing-pclose problem.
diff --git a/contrib/pgbench/pgbench.c b/contrib/pgbench/pgbench.c
@@ -2299,6 +2299,10 @@ printResults(int ttype, int64 normal_xacts, int nclients,
 			   normal_xacts);
 	}
 
+	/* Remaining stats are nonsensical if we failed to execute any xacts */
+	if (normal_xacts <= 0)
+		return;
+
 	if (throttle_delay || progress)
 	{
 		/* compute and show latency average and standard deviation */

Original file line number	Diff line number	Diff line change
`@@ -2299,6 +2299,10 @@ printResults(int ttype, int64 normal_xacts, int nclients,`
`2299`	`2299`	`normal_xacts);`
`2300`	`2300`	`}`
`2301`	`2301`
	`2302`	`+ /* Remaining stats are nonsensical if we failed to execute any xacts */`
	`2303`	`+ if (normal_xacts <= 0)`
	`2304`	`+ return;`
	`2305`	`+`
`2302`	`2306`	`if (throttle_delay \|\| progress)`
`2303`	`2307`	`{`
`2304`	`2308`	`/* compute and show latency average and standard deviation */`