Skip to content

Commit f9f2fda

Browse files
author
Etsuro Fujita
committed
Doc: Update FDW documentation about direct foreign table modification.
1. Commit 7086be6 should have documented the limitation that the direct modification is disabled when WCO constraints are present, but didn't, which is definitely my fault. Update the documentation (Postgres 9.6 onwards). 2. Commit fc22b66 should have documented the limitation that the direct modification is disabled when generated columns are defined, but didn't. Update the documentation (Postgres 12 onwards). Author: Etsuro Fujita Discussion: https://postgr.es/m/CAPmGK14AYCPunLb6TRz1CQsW5Le01Z2ox8LSOKH0P-cOVDcQRA%40mail.gmail.com
1 parent 4877049 commit f9f2fda

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

doc/src/sgml/fdwhandler.sgml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -820,9 +820,11 @@ IsForeignRelUpdatable(Relation rel);
820820
row-by-row approach is necessary, but it can be inefficient. If it is
821821
possible for the foreign server to determine which rows should be
822822
modified without actually retrieving them, and if there are no local
823-
triggers which would affect the operation, then it is possible to
824-
arrange things so that the entire operation is performed on the remote
825-
server. The interfaces described below make this possible.
823+
structures which would affect the operation (row-level local triggers,
824+
stored generated columns, or <literal>WITH CHECK OPTION</literal>
825+
constraints from parent views), then it is possible to arrange things
826+
so that the entire operation is performed on the remote server. The
827+
interfaces described below make this possible.
826828
</para>
827829

828830
<para>

doc/src/sgml/postgres-fdw.sgml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -504,9 +504,9 @@
504504
sending the whole query to the remote server if there are no query
505505
<literal>WHERE</literal> clauses that cannot be sent to the remote server,
506506
no local joins for the query, no row-level local <literal>BEFORE</literal> or
507-
<literal>AFTER</literal> triggers on the target table, and no
508-
<literal>CHECK OPTION</literal> constraints from parent views.
509-
In <command>UPDATE</command>,
507+
<literal>AFTER</literal> triggers or stored generated columns on the target
508+
table, and no <literal>CHECK OPTION</literal> constraints from parent
509+
views. In <command>UPDATE</command>,
510510
expressions to assign to target columns must use only built-in data types,
511511
<literal>IMMUTABLE</literal> operators, or <literal>IMMUTABLE</literal> functions,
512512
to reduce the risk of misexecution of the query.

0 commit comments

Comments
 (0)