valgrind: Adjust suppressions to handle glibc changes

anarazel · anarazel · commit fb9023533de4 · 2025-03-06T08:46:42.000-05:00
In newer glibc versions two additional functions appear between send() and socketcall.send(msg): fun:__internal_syscall_cancel fun:__syscall_cancel Due to that our existing suppression do not work anymore. Use '...', like aleady used in other suppressions, to make valgrind ignore these interstitial frames. The problematic suppressions are only in < 15, as they aren't needed after 5891c7a. Discussion: https://postgr.es/m/d7pyc6wbo2rqhfk24lsgz37766n75vty4jxy5dnppny7ezd4qc@56juadvntebw Backpatch-through: 13
diff --git a/src/tools/valgrind.supp b/src/tools/valgrind.supp
@@ -19,6 +19,7 @@
 	Memcheck:Param
 	socketcall.send(msg)
 
+	...
 	fun:*send*
 	fun:pgstat_send
 }
@@ -28,6 +29,7 @@
 	Memcheck:Param
 	socketcall.sendto(msg)
 
+	...
 	fun:*send*
 	fun:pgstat_send
 }

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@`
`19`	`19`	`Memcheck:Param`
`20`	`20`	`socketcall.send(msg)`
`21`	`21`
	`22`	`+ ...`
`22`	`23`	`fun:send`
`23`	`24`	`fun:pgstat_send`
`24`	`25`	`}`
`@@ -28,6 +29,7 @@`
`28`	`29`	`Memcheck:Param`
`29`	`30`	`socketcall.sendto(msg)`
`30`	`31`
	`32`	`+ ...`
`31`	`33`	`fun:send`
`32`	`34`	`fun:pgstat_send`
`33`	`35`	`}`