Skip to content

Commit fcdd668

Browse files
committed
Harden xxx_is_visible() functions against concurrent object drops.
For the same reasons given in commit 403ac22, adjust these functions to not assume that checking SearchSysCacheExists can guarantee success of a later fetch. This follows the same internal API choices made in the earlier commit: add a function XXXExt(oid, is_missing) and use that to eliminate the need for a separate existence check. The changes are very straightforward, though tedious. For the moment I just made the new functions static in namespace.c, but we could export them if a need emerges. Per bug #18014 from Alexander Lakhin. Given the lack of hard evidence that there's a bug in non-debug builds, I'm content to fix this only in HEAD. Discussion: https://postgr.es/m/18014-28c81cb79d44295d@postgresql.org
1 parent 403ac22 commit fcdd668

File tree

2 files changed

+343
-46
lines changed

2 files changed

+343
-46
lines changed

0 commit comments

Comments
 (0)