Merge branch 'restore-dump-location' into 'master'

agneum · agneum · commit 1e04969c7398 · 2023-08-14T05:50:14.000Z
fix: for  logicalRestore job, verify that dumpLocation exists in filesystem

See merge request postgres-ai/database-lab!801
diff --git a/engine/internal/retrieval/engine/postgres/logical/restore.go b/engine/internal/retrieval/engine/postgres/logical/restore.go
@@ -10,6 +10,7 @@ import (
 	"bytes"
 	"context"
 	"fmt"
+	"io/fs"
 	"os"
 	"path"
 	"path/filepath"
@@ -165,7 +166,18 @@ func (r *RestoreJob) Reload(cfg map[string]interface{}) (err error) {
 
 	stat, err := os.Stat(r.RestoreOptions.DumpLocation)
 	if err != nil {
-		return errors.Wrap(err, "dumpLocation not found")
+		if !errors.Is(err, fs.ErrNotExist) {
+			return errors.Wrap(err, "cannot get stats of dumpLocation")
+		}
+
+		if err := os.MkdirAll(r.RestoreOptions.DumpLocation, 0666); err != nil {
+			return fmt.Errorf("error creating dumpLocation directory:  %w", err)
+		}
+
+		stat, err = os.Stat(r.RestoreOptions.DumpLocation)
+		if err != nil {
+			return fmt.Errorf("cannot get stats of dumpLocation: %w", err)
+		}
 	}
 
 	r.isDumpLocationDir = stat.IsDir()
